Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 1381073003: Disable vector store ICs for mjsunit/call-counts because slot indices change when --vector-store… (Closed)

Created:
5 years, 2 months ago by Igor Sheludko
Modified:
5 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disable vector store ICs for mjsunit/call-counts because slot indices change when --vector-stores is enabled. Committed: https://crrev.com/898524afcea3e047d3a50ea19705af2e3f172e80 Cr-Commit-Position: refs/heads/master@{#31059}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M test/mjsunit/call-counts.js View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Igor Sheludko
PTAL
5 years, 2 months ago (2015-10-01 17:18:27 UTC) #2
Igor Sheludko
PTAL
5 years, 2 months ago (2015-10-01 17:18:28 UTC) #3
Jakob Kummerow
LGTM with comment. https://codereview.chromium.org/1381073003/diff/1/test/mjsunit/call-counts.js File test/mjsunit/call-counts.js (right): https://codereview.chromium.org/1381073003/diff/1/test/mjsunit/call-counts.js#newcode5 test/mjsunit/call-counts.js:5: // Flags: --allow-natives-syntax --noalways-opt --no-vector-stores Please ...
5 years, 2 months ago (2015-10-01 17:27:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1381073003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1381073003/20001
5 years, 2 months ago (2015-10-01 17:33:40 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-01 18:03:40 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 18:03:55 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/898524afcea3e047d3a50ea19705af2e3f172e80
Cr-Commit-Position: refs/heads/master@{#31059}

Powered by Google App Engine
This is Rietveld 408576698