Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 1381033002: Add data-URI support class to dart:core (next to Uri). (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Remove VM assertion that appears to be incorrect. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph_optimizer.cc
diff --git a/runtime/vm/flow_graph_optimizer.cc b/runtime/vm/flow_graph_optimizer.cc
index b2ef8b35edf4f2d903b2fc093202aa0c9b89ad53..8bee936ff342ba02d509e93c266030de0b44c72b 100644
--- a/runtime/vm/flow_graph_optimizer.cc
+++ b/runtime/vm/flow_graph_optimizer.cc
@@ -177,9 +177,6 @@ bool FlowGraphOptimizer::TryCreateICData(InstanceCallInstr* call) {
// Do not make the instance call megamorphic if the callee needs to decode
// the calling code sequence to lookup the ic data and verify if a warning
// has already been issued or not.
- // TryCreateICData is only invoked if the ic_data target has not been called
- // yet, so no warning can possibly have been issued.
- ASSERT(!call->ic_data()->IssuedJSWarning());
Lasse Reichstein Nielsen 2015/11/12 11:48:25 This was hit by standalone/javascript_compatibilit
Florian Schneider 2015/11/12 11:51:10 The reason you hit this is because the string inte
if (call->ic_data()->MayCheckForJSWarning()) {
return false;
}
« CHANGELOG.md ('K') | « runtime/bin/builtin.dart ('k') | sdk/lib/convert/base64.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698