runtime/bin/dartutils.h - Issue 1381033002: Add data-URI support class to dart:core (next to Uri).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/dartutils.h

Issue 1381033002: Add data-URI support class to dart:core (next to Uri). (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Add more tests, refactor, rename to DataUriHelper. Need better name! Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/dartutils.h

diff --git a/runtime/bin/dartutils.h b/runtime/bin/dartutils.h

index 6626a3f5b91318ed69d51342b78cc7161ff47235..4d27f2f9b92c7d55e1e0df90ecd2b12b0786b1f1 100644

--- a/runtime/bin/dartutils.h

+++ b/runtime/bin/dartutils.h

@@ -132,11 +132,11 @@ class DartUtils {

const char* package_root,

const char** package_map,

const char* packages_file);

- static Dart_Handle PrepareCoreLibrary(Dart_Handle core_lib,

- Dart_Handle builtin_lib,

- bool is_service_isolate);

+ static Dart_Handle PrepareUriLibrary(Dart_Handle uri_lib,

+ Dart_Handle builtin_lib,

+ bool is_service_isolate);

static Dart_Handle PrepareAsyncLibrary(Dart_Handle async_lib,

- Dart_Handle isolate_lib);

+ Dart_Handle isolate_lib);

static Dart_Handle PrepareIOLibrary(Dart_Handle io_lib);

static Dart_Handle PrepareIsolateLibrary(Dart_Handle isolate_lib);

static Dart_Handle PrepareForScriptLoading(const char* package_root,