mac: Don’t leak send rights from ExceptionPorts::GetExceptionPorts()

mac: Don’t leak send rights from ExceptionPorts::GetExceptionPorts()

ExceptionPorts::GetExceptionPorts() returned a
std::vector<ExceptionPorts::ExceptionHandler>, which contained send
rights to Mach ports. The interface required callers to assume ownership
of each send right contained within the vector. This was cumbersome and
error-prone, and despite the care taken in Crashpad, port right leaks
did occur:

 - SimulateCrash() didn’t make any attempt to release these resources at
   all.
 - Neither did crashpad_util_test ExceptionPorts.HostExceptionPorts,
   which also reused a vector.

This replaces the vector with the interface-compatible (as far as
necessary) ExceptionPorts::ExceptionHandlerVector, which deallocates
collected port rights on destruction or clear().

R=rsesek@chromium.org

Committed: https://chromium.googlesource.com/crashpad/crashpad/+/5f7eda87a6fa32b8881464950dacb006180a4edb

[Mark Mentovai, 2015-10-05 22:21:17]

mark@chromium.org changed reviewers:
+ rsesek@chromium.org

[Robert Sesek, 2015-10-06 18:54:24]

LGTM

[Mark Mentovai, 2015-10-06 20:14:37]

Committed patchset #1 (id:1) manually as
5f7eda87a6fa32b8881464950dacb006180a4edb (presubmit successful).