Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1657)

Unified Diff: content/child/blink_platform_impl.cc

Issue 1381023002: NOCOMMIT: Blink tracing now uses base Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/blink_platform_impl.h ('k') | third_party/WebKit/Source/bindings/core/v8/V8Binding.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/blink_platform_impl.cc
diff --git a/content/child/blink_platform_impl.cc b/content/child/blink_platform_impl.cc
index c8f41688a6fb8017f9075e160af300c0d5673640..513fc534fadb1621ffc470665276494b212d700b 100644
--- a/content/child/blink_platform_impl.cc
+++ b/content/child/blink_platform_impl.cc
@@ -157,25 +157,6 @@ class MemoryUsageCache {
base::Lock lock_;
};
-class ConvertableToTraceFormatWrapper
- : public base::trace_event::ConvertableToTraceFormat {
- public:
- // We move a reference pointer from |convertable| to |convertable_|,
- // rather than copying, for thread safety. https://crbug.com/478149
- explicit ConvertableToTraceFormatWrapper(
- blink::WebConvertableToTraceFormat& convertable) {
- convertable_.moveFrom(convertable);
- }
- void AppendAsTraceFormat(std::string* out) const override {
- *out += convertable_.asTraceFormat().utf8();
- }
-
- private:
- ~ConvertableToTraceFormatWrapper() override {}
-
- blink::WebConvertableToTraceFormat convertable_;
-};
-
} // namespace
static int ToMessageID(WebLocalizedString::Name name) {
@@ -615,94 +596,6 @@ BlinkPlatformImpl::getTraceSamplingState(const unsigned thread_bucket) {
return NULL;
}
-static_assert(
- sizeof(blink::Platform::TraceEventHandle) ==
- sizeof(base::trace_event::TraceEventHandle),
- "TraceEventHandle types must be same size");
-
-blink::Platform::TraceEventHandle BlinkPlatformImpl::addTraceEvent(
- char phase,
- const unsigned char* category_group_enabled,
- const char* name,
- unsigned long long id,
- unsigned long long bind_id,
- double timestamp,
- int num_args,
- const char** arg_names,
- const unsigned char* arg_types,
- const unsigned long long* arg_values,
- blink::WebConvertableToTraceFormat* convertable_values,
- unsigned int flags) {
- scoped_refptr<base::trace_event::ConvertableToTraceFormat>
- convertable_wrappers[2];
- if (convertable_values) {
- size_t size = std::min(static_cast<size_t>(num_args),
- arraysize(convertable_wrappers));
- for (size_t i = 0; i < size; ++i) {
- if (arg_types[i] == TRACE_VALUE_TYPE_CONVERTABLE) {
- convertable_wrappers[i] =
- new ConvertableToTraceFormatWrapper(convertable_values[i]);
- }
- }
- }
- base::TraceTicks timestamp_tt =
- base::TraceTicks() + base::TimeDelta::FromSecondsD(timestamp);
- base::trace_event::TraceEventHandle handle =
- TRACE_EVENT_API_ADD_TRACE_EVENT_WITH_THREAD_ID_AND_TIMESTAMP(
- phase, category_group_enabled, name, id, trace_event_internal::kNoId,
- bind_id, base::PlatformThread::CurrentId(), timestamp_tt, num_args,
- arg_names, arg_types, arg_values, convertable_wrappers, flags);
- blink::Platform::TraceEventHandle result;
- memcpy(&result, &handle, sizeof(result));
- return result;
-}
-
-blink::Platform::TraceEventHandle BlinkPlatformImpl::addTraceEvent(
- char phase,
- const unsigned char* category_group_enabled,
- const char* name,
- unsigned long long id,
- double timestamp,
- int num_args,
- const char** arg_names,
- const unsigned char* arg_types,
- const unsigned long long* arg_values,
- blink::WebConvertableToTraceFormat* convertable_values,
- unsigned char flags) {
- scoped_refptr<base::trace_event::ConvertableToTraceFormat>
- convertable_wrappers[2];
- if (convertable_values) {
- size_t size = std::min(static_cast<size_t>(num_args),
- arraysize(convertable_wrappers));
- for (size_t i = 0; i < size; ++i) {
- if (arg_types[i] == TRACE_VALUE_TYPE_CONVERTABLE) {
- convertable_wrappers[i] =
- new ConvertableToTraceFormatWrapper(convertable_values[i]);
- }
- }
- }
- base::TraceTicks timestamp_tt =
- base::TraceTicks() + base::TimeDelta::FromSecondsD(timestamp);
- base::trace_event::TraceEventHandle handle =
- TRACE_EVENT_API_ADD_TRACE_EVENT_WITH_THREAD_ID_AND_TIMESTAMP(
- phase, category_group_enabled, name, id, trace_event_internal::kNoId,
- base::PlatformThread::CurrentId(), timestamp_tt, num_args, arg_names,
- arg_types, arg_values, convertable_wrappers, flags);
- blink::Platform::TraceEventHandle result;
- memcpy(&result, &handle, sizeof(result));
- return result;
-}
-
-void BlinkPlatformImpl::updateTraceEventDuration(
- const unsigned char* category_group_enabled,
- const char* name,
- TraceEventHandle handle) {
- base::trace_event::TraceEventHandle traceEventHandle;
- memcpy(&traceEventHandle, &handle, sizeof(handle));
- TRACE_EVENT_API_UPDATE_TRACE_EVENT_DURATION(
- category_group_enabled, name, traceEventHandle);
-}
-
void BlinkPlatformImpl::registerMemoryDumpProvider(
blink::WebMemoryDumpProvider* wmdp) {
WebMemoryDumpProviderAdapter* wmdp_adapter =
« no previous file with comments | « content/child/blink_platform_impl.h ('k') | third_party/WebKit/Source/bindings/core/v8/V8Binding.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698