tools/perf/measurements/v8_detached_context_age_in_gc_unittest.py - Issue 1381003004: Better distinguish didFinishLoad and didStopLoading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/v8_detached_context_age_in_gc_unittest.py

Issue 1381003004: Better distinguish didFinishLoad and didStopLoading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/measurements/v8_detached_context_age_in_gc_unittest.py

diff --git a/tools/perf/measurements/v8_detached_context_age_in_gc_unittest.py b/tools/perf/measurements/v8_detached_context_age_in_gc_unittest.py

index 1d9151acb43c07cee57f374f2276f3f0302ad2b9..eded79a9da44a3382d4ab869e45ece89fa234174 100644

--- a/tools/perf/measurements/v8_detached_context_age_in_gc_unittest.py

+++ b/tools/perf/measurements/v8_detached_context_age_in_gc_unittest.py

@@ -91,7 +91,7 @@ class V8DetachedContextAgeInGCTests(page_test_test_case.PageTestTestCase):

page_set.AddStory(page)

metric = v8_detached_context_age_in_gc.V8DetachedContextAgeInGC()

results = self.RunMeasurement(metric, page_set, options=self._options)

- self.assertEquals(0, len(results.failures))

+ self.assertEquals(0, len(results.failures), msg=str(results.failures))

actual = _ActualValues(results)['V8_DetachedContextAgeInGC']

self.assertLessEqual(0, actual.value)

self.assertEqual('garbage_collections', actual.units)

« no previous file with comments | « third_party/WebKit/public/web/WebFrame.h ('k') | no next file » | no next file with comments »