Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Unified Diff: components/test_runner/test_runner.cc

Issue 1381003004: Better distinguish didFinishLoad and didStopLoading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/test_runner/test_runner.h ('k') | components/test_runner/web_frame_test_proxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/test_runner/test_runner.cc
diff --git a/components/test_runner/test_runner.cc b/components/test_runner/test_runner.cc
index 610676155fe6f62257b4bf91d2180f13db4b61ea..996cd3581991a805e1443daf00c71f68e291e11f 100644
--- a/components/test_runner/test_runner.cc
+++ b/components/test_runner/test_runner.cc
@@ -246,7 +246,6 @@ class TestRunnerBindings : public gin::Wrappable<TestRunnerBindings> {
void SetAllowRunningOfInsecureContent(bool allowed);
void DumpPermissionClientCallbacks();
void DumpWindowStatusChanges();
- void DumpProgressFinishedCallback();
void DumpSpellCheckCallbacks();
void DumpBackForwardList();
void DumpSelectionRect();
@@ -505,8 +504,6 @@ gin::ObjectTemplateBuilder TestRunnerBindings::GetObjectTemplateBuilder(
&TestRunnerBindings::DumpPermissionClientCallbacks)
.SetMethod("dumpWindowStatusChanges",
&TestRunnerBindings::DumpWindowStatusChanges)
- .SetMethod("dumpProgressFinishedCallback",
- &TestRunnerBindings::DumpProgressFinishedCallback)
.SetMethod("dumpSpellCheckCallbacks",
&TestRunnerBindings::DumpSpellCheckCallbacks)
.SetMethod("dumpBackForwardList",
@@ -1211,11 +1208,6 @@ void TestRunnerBindings::DumpWindowStatusChanges() {
runner_->DumpWindowStatusChanges();
}
-void TestRunnerBindings::DumpProgressFinishedCallback() {
- if (runner_)
- runner_->DumpProgressFinishedCallback();
-}
-
void TestRunnerBindings::DumpSpellCheckCallbacks() {
if (runner_)
runner_->DumpSpellCheckCallbacks();
@@ -1720,7 +1712,6 @@ void TestRunner::Reset() {
dump_resource_request_callbacks_ = false;
dump_resource_response_mime_types_ = false;
dump_window_status_changes_ = false;
- dump_progress_finished_callback_ = false;
dump_spell_check_callbacks_ = false;
dump_back_forward_list_ = false;
dump_selection_rect_ = false;
@@ -1895,10 +1886,6 @@ bool TestRunner::shouldDumpStatusCallbacks() const {
return dump_window_status_changes_;
}
-bool TestRunner::shouldDumpProgressFinishedCallback() const {
- return dump_progress_finished_callback_;
-}
-
bool TestRunner::shouldDumpSpellCheckCallbacks() const {
return dump_spell_check_callbacks_;
}
@@ -2746,10 +2733,6 @@ void TestRunner::DumpWindowStatusChanges() {
dump_window_status_changes_ = true;
}
-void TestRunner::DumpProgressFinishedCallback() {
- dump_progress_finished_callback_ = true;
-}
-
void TestRunner::DumpSpellCheckCallbacks() {
dump_spell_check_callbacks_ = true;
}
« no previous file with comments | « components/test_runner/test_runner.h ('k') | components/test_runner/web_frame_test_proxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698