chrome/android/javatests/src/org/chromium/chrome/browser/GeolocationTest.java - Issue 1381003004: Better distinguish didFinishLoad and didStopLoading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/GeolocationTest.java

Issue 1381003004: Better distinguish didFinishLoad and didStopLoading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/HistoryUITest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/GeolocationTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/GeolocationTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/GeolocationTest.java

index 6733cdc1ae2d0fed2020f3ca852613aa3151df84..32c7b70514992c7ea6561232e29f90bacd5cfced 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/GeolocationTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/GeolocationTest.java

@@ -92,7 +92,7 @@ public class GeolocationTest extends ChromeActivityTestCaseBase<ChromeActivity>

final CallbackHelper loadCallback = new CallbackHelper();

TabObserver observer = new EmptyTabObserver() {

@Override

- public void onLoadStopped(Tab tab) {

+ public void onLoadStopped(Tab tab, boolean toDifferentDocument) {

// If the device has a cached non-mock location, we won't get back our

// lat/long, so checking that it has "#pass" is sufficient.

if (tab.getUrl().startsWith(url + "#pass|")) {

@@ -129,7 +129,7 @@ public class GeolocationTest extends ChromeActivityTestCaseBase<ChromeActivity>

final CallbackHelper loadCallback0 = new CallbackHelper();

TabObserver observer = new EmptyTabObserver() {

@Override

- public void onLoadStopped(Tab tab) {

+ public void onLoadStopped(Tab tab, boolean toDifferentDocument) {

// If the device has a cached non-mock location, we won't get back our

// lat/long, so checking that it has "#pass" is sufficient.

if (tab.getUrl().startsWith(url + "#pass|0|")) {

@@ -153,7 +153,7 @@ public class GeolocationTest extends ChromeActivityTestCaseBase<ChromeActivity>

final CallbackHelper loadCallback1 = new CallbackHelper();

observer = new EmptyTabObserver() {

@Override

- public void onLoadStopped(Tab tab) {

+ public void onLoadStopped(Tab tab, boolean toDifferentDocument) {

// If the device has a cached non-mock location, we won't get back our

// lat/long, so checking that it has "#pass" is sufficient.

if (tab.getUrl().startsWith(url + "#pass|1|")) {