components/web_contents_delegate_android/web_contents_delegate_android.cc - Issue 1381003004: Better distinguish didFinishLoad and didStopLoading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_contents_delegate_android/web_contents_delegate_android.cc

Issue 1381003004: Better distinguish didFinishLoad and didStopLoading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't pulse progress bar for same-document navs Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java ('K') | « components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java ('k') | third_party/WebKit/LayoutTests/http/tests/loading/progress-finished-callback.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/web_contents_delegate_android/web_contents_delegate_android.cc

diff --git a/components/web_contents_delegate_android/web_contents_delegate_android.cc b/components/web_contents_delegate_android/web_contents_delegate_android.cc

index 337044c74d76b111be503bac89cd329505a2caf5..b535eb3dbd43c3817db29b414ae7d0c3c0b15a73 100644

--- a/components/web_contents_delegate_android/web_contents_delegate_android.cc

+++ b/components/web_contents_delegate_android/web_contents_delegate_android.cc

@@ -177,10 +177,14 @@ void WebContentsDelegateAndroid::LoadingStateChanged(WebContents* source,

return;

bool has_stopped = source == NULL || !source->IsLoading();

- if (has_stopped)

+ if (has_stopped) {

Java_WebContentsDelegateAndroid_onLoadStopped(env, obj.obj());

- else

- Java_WebContentsDelegateAndroid_onLoadStarted(env, obj.obj());

+ } else {

+ Java_WebContentsDelegateAndroid_onLoadStarted(

+ env,

+ obj.obj(),

+ to_different_document);

+ }

}

void WebContentsDelegateAndroid::LoadProgressChanged(WebContents* source,