components/test_runner/web_test_proxy.cc - Issue 1381003004: Better distinguish didFinishLoad and didStopLoading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/web_test_proxy.cc

Issue 1381003004: Better distinguish didFinishLoad and didStopLoading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't pulse progress bar for same-document navs Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java ('K') | « components/test_runner/web_test_proxy.h ('k') | components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/test_runner/web_test_proxy.cc

diff --git a/components/test_runner/web_test_proxy.cc b/components/test_runner/web_test_proxy.cc

index 227f6ef7f8e90cef7c325e7d2bc9eb1884edca20..8e7c08f5a567390e14ed8cbb6c326167859976ef 100644

--- a/components/test_runner/web_test_proxy.cc

+++ b/components/test_runner/web_test_proxy.cc

@@ -971,11 +971,6 @@ void WebTestProxyBase::SetStatusText(const blink::WebString& text) {

text.utf8().data() + "\n");

}

-void WebTestProxyBase::DidStopLoading() {

- if (test_interfaces_->GetTestRunner()->shouldDumpProgressFinishedCallback())

- delegate_->PrintMessage("postProgressFinishedNotification\n");

void WebTestProxyBase::ShowContextMenu(

const blink::WebContextMenuData& context_menu_data) {

test_interfaces_->GetEventSender()->SetContextMenuData(context_menu_data);