chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java - Issue 1381003004: Better distinguish didFinishLoad and didStopLoading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java

Issue 1381003004: Better distinguish didFinishLoad and didStopLoading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't pulse progress bar for same-document navs Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/tab/TabObserver.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java

index 7b2b102b0f8e189cb2d7e63c14455c766d2dfdb8..23946c5b7f9cc462876a3584ca222e51b1d182cc 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java

@@ -185,19 +185,13 @@ public class TabWebContentsDelegateAndroid extends WebContentsDelegateAndroid {

}

@Override

- public void onLoadStarted() {

- RewindableIterator<TabObserver> observers = mTab.getTabObservers();

- while (observers.hasNext()) {

- observers.next().onLoadStarted(mTab);

- }

+ public void onLoadStarted(boolean toDifferentDocument) {

+ mTab.onLoadStarted(toDifferentDocument);

}

@Override

public void onLoadStopped() {

- RewindableIterator<TabObserver> observers = mTab.getTabObservers();

- while (observers.hasNext()) {

- observers.next().onLoadStopped(mTab);

- }

+ mTab.onLoadStopped();

}

@Override