Better distinguish didFinishLoad and didStopLoading

chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
index 5b88514e35a2aaec0f1b7c1cd8336e634ebb0981..98238e1befd060218f7649f8b18600dacfffc196 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
@@ -1379,6 +1379,16 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
         nativeDetachOverlayContentViewCore(mNativeTabAndroid, content);
     }
 
+    protected void onLoadStarted() {

[Ted C, 2015/10/27 23:07:19]

javadoc non-private methods

[Nate Chapin, 2015/10/28 20:57:39]

Done.

+        mIsLoading = true;
+        for (TabObserver observer : mObservers) observer.onLoadStarted(this);
+    }
+
+    protected void onLoadStopped() {
+        mIsLoading = false;
+        for (TabObserver observer : mObservers) observer.onLoadStopped(this);
+    }
+
     /**
      * Called when a page has started loading.
      * @param validatedUrl URL being loaded.
@@ -1388,7 +1398,6 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
         mIsFullscreenWaitingForLoad = !DomDistillerUrlUtils.isDistilledPage(validatedUrl);
 
         mIsShowingErrorPage = showingErrorPage;
-        mIsLoading = true;
 
         updateTitle();
         removeSadTabIfPresent();
@@ -1402,7 +1411,6 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
      * Called when a page has finished loading.
      */
     protected void didFinishPageLoad() {
-        mIsLoading = false;
         mIsBeingRestored = false;
         mIsTabStateDirty = true;
         updateTitle();
@@ -1435,7 +1443,6 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
      */
     protected void didFailPageLoad(int errorCode) {
         cancelEnableFullscreenLoadDelay();
-        mIsLoading = false;
         mIsBeingRestored = false;
         if (mTabUma != null) mTabUma.onLoadFailed(errorCode);
         for (TabObserver observer : mObservers) observer.onPageLoadFailed(this, errorCode);