components/test_runner/web_test_proxy.cc - Issue 1381003004: Better distinguish didFinishLoad and didStopLoading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/web_test_proxy.cc

Issue 1381003004: Better distinguish didFinishLoad and didStopLoading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix WebFrameTest.CallbackOrdering race Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/web_navigation/web_navigation_api.cc ('K') | « components/test_runner/web_test_proxy.h ('k') | third_party/WebKit/LayoutTests/http/tests/loading/progress-finished-callback.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/test_runner/web_test_proxy.cc

diff --git a/components/test_runner/web_test_proxy.cc b/components/test_runner/web_test_proxy.cc

index 1dc3bf2d2fa24d8cac96d9f99ead835293bee3a7..cf09e8373df1d51c8d3d2418d9fe0f0269686b8b 100644

--- a/components/test_runner/web_test_proxy.cc

+++ b/components/test_runner/web_test_proxy.cc

@@ -974,11 +974,6 @@ void WebTestProxyBase::SetStatusText(const blink::WebString& text) {

text.utf8().data() + "\n");

}

-void WebTestProxyBase::DidStopLoading() {

- if (test_interfaces_->GetTestRunner()->shouldDumpProgressFinishedCallback())

- delegate_->PrintMessage("postProgressFinishedNotification\n");

void WebTestProxyBase::ShowContextMenu(

const blink::WebContextMenuData& context_menu_data) {

test_interfaces_->GetEventSender()->SetContextMenuData(context_menu_data);