components/test_runner/web_frame_test_proxy.h - Issue 1381003004: Better distinguish didFinishLoad and didStopLoading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/web_frame_test_proxy.h

Issue 1381003004: Better distinguish didFinishLoad and didStopLoading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix WebFrameTest.CallbackOrdering race Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/web_navigation/web_navigation_api.cc ('K') | « components/test_runner/test_runner.cc ('k') | components/test_runner/web_test_proxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/test_runner/web_frame_test_proxy.h

diff --git a/components/test_runner/web_frame_test_proxy.h b/components/test_runner/web_frame_test_proxy.h

index e7e428f0c88d5b50c2c59f7cb5c225c1db437bf9..b2a61f8c77bbac427a13848078204d8ebbd59a15 100644

--- a/components/test_runner/web_frame_test_proxy.h

+++ b/components/test_runner/web_frame_test_proxy.h

@@ -266,11 +266,6 @@ class WebFrameTestProxy : public Base {

source_frame, target_frame, target, event);

}

- virtual void didStopLoading() {

- base_proxy_->DidStopLoading();

- Base::didStopLoading();

- }

virtual void postAccessibilityEvent(const blink::WebAXObject& object,

blink::WebAXEvent event) {

base_proxy_->PostAccessibilityEvent(object, event);