third_party/WebKit/LayoutTests/http/tests/loading/progress-finished-callback-expected.txt - Issue 1381003004: Better distinguish didFinishLoad and didStopLoading

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/loading/progress-finished-callback-expected.txt

Issue 1381003004: Better distinguish didFinishLoad and didStopLoading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/autofill/content/renderer/password_autofill_agent.cc ('K') | « third_party/WebKit/LayoutTests/http/tests/loading/progress-finished-callback.html ('k') | third_party/WebKit/Source/core/loader/DocumentLoader.h » ('j') | third_party/WebKit/Source/core/loader/DocumentLoader.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 main frame - didStartProvisionalLoadForFrame

2 main frame - didCommitLoadForFrame

3 main frame - didFinishDocumentLoadForFrame

4 main frame - didHandleOnloadEventsForFrame

5 postProgressFinishedNotification

6 main frame - didFinishLoadForFrame

7 This is a test of progress finished callback ordering in relation to frame loade r callbacks. It is only useful inside the regression test tool.
dcheng 2015/10/08 05:34:35 It might be nice to keep this and just update the It might be nice to keep this and just update the expected result: it seems nice to have this order 'enforced' in a test somewhere. Nate Chapin 2015/10/08 21:03:59 Translated to WebFrameTest. Show quoted text On 2015/10/08 05:34:35, dcheng wrote: > It might be nice to keep this and just update the expected result: it seems nice > to have this order 'enforced' in a test somewhere. Translated to WebFrameTest.
OLD	NEW