Better distinguish didFinishLoad and didStopLoading

components/test_runner/test_runner.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/test_runner/test_runner.h"
 
 #include <limits>
 
 #include "base/logging.h"
 #include "build/build_config.h"
@@ skipping 228 matching lines @@
   void DumpResourceResponseMIMETypes();
   void SetImagesAllowed(bool allowed);
   void SetMediaAllowed(bool allowed);
   void SetScriptsAllowed(bool allowed);
   void SetStorageAllowed(bool allowed);
   void SetPluginsAllowed(bool allowed);
   void SetAllowDisplayOfInsecureContent(bool allowed);
   void SetAllowRunningOfInsecureContent(bool allowed);
   void DumpPermissionClientCallbacks();
   void DumpWindowStatusChanges();
-  void DumpProgressFinishedCallback();
   void DumpSpellCheckCallbacks();
   void DumpBackForwardList();
   void DumpSelectionRect();
   void SetPrinting();
   void ClearPrinting();
   void SetShouldStayOnPageAfterHandlingBeforeUnload(bool value);
   void SetWillSendRequestClearHeader(const std::string& header);
   void DumpResourceRequestPriorities();
   void SetUseMockTheme(bool use);
   void WaitUntilExternalURLLoad();
@@ skipping 238 matching lines @@
       .SetMethod("setStorageAllowed", &TestRunnerBindings::SetStorageAllowed)
       .SetMethod("setPluginsAllowed", &TestRunnerBindings::SetPluginsAllowed)
       .SetMethod("setAllowDisplayOfInsecureContent",
                  &TestRunnerBindings::SetAllowDisplayOfInsecureContent)
       .SetMethod("setAllowRunningOfInsecureContent",
                  &TestRunnerBindings::SetAllowRunningOfInsecureContent)
       .SetMethod("dumpPermissionClientCallbacks",
                  &TestRunnerBindings::DumpPermissionClientCallbacks)
       .SetMethod("dumpWindowStatusChanges",
                  &TestRunnerBindings::DumpWindowStatusChanges)
-      .SetMethod("dumpProgressFinishedCallback",
-                 &TestRunnerBindings::DumpProgressFinishedCallback)
       .SetMethod("dumpSpellCheckCallbacks",
                  &TestRunnerBindings::DumpSpellCheckCallbacks)
       .SetMethod("dumpBackForwardList",
                  &TestRunnerBindings::DumpBackForwardList)
       .SetMethod("dumpSelectionRect", &TestRunnerBindings::DumpSelectionRect)
       .SetMethod("setPrinting", &TestRunnerBindings::SetPrinting)
       .SetMethod("clearPrinting", &TestRunnerBindings::ClearPrinting)
       .SetMethod(
           "setShouldStayOnPageAfterHandlingBeforeUnload",
           &TestRunnerBindings::SetShouldStayOnPageAfterHandlingBeforeUnload)
@@ skipping 684 matching lines @@
 void TestRunnerBindings::DumpPermissionClientCallbacks() {
   if (runner_)
     runner_->DumpPermissionClientCallbacks();
 }
 
 void TestRunnerBindings::DumpWindowStatusChanges() {
   if (runner_)
     runner_->DumpWindowStatusChanges();
 }
 
-void TestRunnerBindings::DumpProgressFinishedCallback() {
-  if (runner_)
-    runner_->DumpProgressFinishedCallback();
-}
-
 void TestRunnerBindings::DumpSpellCheckCallbacks() {
   if (runner_)
     runner_->DumpSpellCheckCallbacks();
 }
 
 void TestRunnerBindings::DumpBackForwardList() {
   if (runner_)
     runner_->DumpBackForwardList();
 }
 
@@ skipping 484 matching lines @@
   dump_frame_load_callbacks_ = false;
   dump_ping_loader_callbacks_ = false;
   dump_user_gesture_in_frame_load_callbacks_ = false;
   dump_title_changes_ = false;
   dump_create_view_ = false;
   can_open_windows_ = false;
   dump_resource_load_callbacks_ = false;
   dump_resource_request_callbacks_ = false;
   dump_resource_response_mime_types_ = false;
   dump_window_status_changes_ = false;
-  dump_progress_finished_callback_ = false;
   dump_spell_check_callbacks_ = false;
   dump_back_forward_list_ = false;
   dump_selection_rect_ = false;
   dump_drag_image_ = false;
   dump_navigation_policy_ = false;
   test_repaint_ = false;
   sweep_horizontally_ = false;
   is_printing_ = false;
   midi_accessor_result_ = true;
   should_stay_on_page_after_handling_before_unload_ = false;
@@ skipping 154 matching lines @@
 }
 
 WebContentSettingsClient* TestRunner::GetWebContentSettings() const {
   return web_content_settings_.get();
 }
 
 bool TestRunner::shouldDumpStatusCallbacks() const {
   return dump_window_status_changes_;
 }
 
-bool TestRunner::shouldDumpProgressFinishedCallback() const {
-  return dump_progress_finished_callback_;
-}
-
 bool TestRunner::shouldDumpSpellCheckCallbacks() const {
   return dump_spell_check_callbacks_;
 }
 
 bool TestRunner::ShouldDumpBackForwardList() const {
   return dump_back_forward_list_;
 }
 
 bool TestRunner::shouldDumpSelectionRect() const {
   return dump_selection_rect_;
@@ skipping 827 matching lines @@
 }
 
 void TestRunner::DumpPermissionClientCallbacks() {
   web_content_settings_->SetDumpCallbacks(true);
 }
 
 void TestRunner::DumpWindowStatusChanges() {
   dump_window_status_changes_ = true;
 }
 
-void TestRunner::DumpProgressFinishedCallback() {
-  dump_progress_finished_callback_ = true;
-}
-
 void TestRunner::DumpSpellCheckCallbacks() {
   dump_spell_check_callbacks_ = true;
 }
 
 void TestRunner::DumpBackForwardList() {
   dump_back_forward_list_ = true;
 }
 
 void TestRunner::DumpSelectionRect() {
   dump_selection_rect_ = true;
@@ skipping 390 matching lines @@
 }
 
 void TestRunner::DidLosePointerLockInternal() {
   bool was_locked = pointer_locked_;
   pointer_locked_ = false;
   if (was_locked)
     web_view_->didLosePointerLock();
 }
 
 }  // namespace test_runner