fpdfsdk/src/jsapi/fxjs_v8.cpp - Issue 1380993003: Fix a leak with g_DefaultGlobalObjectTemplate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/jsapi/fxjs_v8.cpp

Issue 1380993003: Fix a leak with g_DefaultGlobalObjectTemplate. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/jsapi/fxjs_v8.cpp

diff --git a/fpdfsdk/src/jsapi/fxjs_v8.cpp b/fpdfsdk/src/jsapi/fxjs_v8.cpp

index bea9f4c4d88a2ce15fabbb1f6d2917eeeac43745..b7951c4f3f68dad09f2e37a1eb47388e968998eb 100644

--- a/fpdfsdk/src/jsapi/fxjs_v8.cpp

+++ b/fpdfsdk/src/jsapi/fxjs_v8.cpp

@@ -145,6 +145,7 @@ void FXJS_Initialize(unsigned int embedderDataSlot, v8::Isolate* pIsolate) {

void FXJS_Release() {

ASSERT(!g_isolate || g_isolate_ref_count == 0);

+ delete g_DefaultGlobalObjectTemplate;

g_DefaultGlobalObjectTemplate = nullptr;

g_isolate = nullptr;

« no previous file with comments | « no previous file | no next file » | no next file with comments »