Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3293)

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc

Issue 1380973003: Add a flag use_software_compositing to the Widget::InitParams structure. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix alignment Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/status_bubble_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc
diff --git a/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc b/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc
index 8f708ab0b358d52370f6708851a4204de4cef196..dd3b74ad29b0e17353346865b466276ca8aacd06 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc
+++ b/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc
@@ -234,17 +234,13 @@ void OmniboxPopupContentsView::UpdatePopupAppearance() {
// If the popup is currently closed, we need to create it.
popup_ = (new AutocompletePopupWidget)->AsWeakPtr();
- // On Windows use TYPE_MENU to ensure that this window uses the software
- // compositor which avoids the UI thread blocking issue during command
- // buffer creation. We can revert this change once http://crbug.com/125248
- // is fixed.
-#if defined(OS_WIN)
- views::Widget::InitParams params(views::Widget::InitParams::TYPE_MENU);
- // The menu style assumes a top most window. We don't want that in this
- // case.
- params.keep_on_top = false;
-#else
+
views::Widget::InitParams params(views::Widget::InitParams::TYPE_POPUP);
+#if defined(OS_WIN)
+ // On Windows use the software compositor to ensure that we don't block
+ // the UI thread blocking issue during command buffer creation. We can
+ // revert this change once http://crbug.com/125248 is fixed.
+ params.force_software_compositing = true;
#endif
params.opacity = views::Widget::InitParams::TRANSLUCENT_WINDOW;
params.parent = popup_parent->GetNativeView();
« no previous file with comments | « no previous file | chrome/browser/ui/views/status_bubble_views.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698