pkg/analyzer/lib/src/generated/resolver.dart - Issue 1380963004: fixes strong mode assignability

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/generated/resolver.dart

Issue 1380963004: fixes strong mode assignability (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/lib/src/generated/resolver.dart

diff --git a/pkg/analyzer/lib/src/generated/resolver.dart b/pkg/analyzer/lib/src/generated/resolver.dart

index 0a197f57d261e147013acad52c3d0f6539c3e276..6393e553b0ddc1d7356251b9ac54fac70fdfea76 100644

--- a/pkg/analyzer/lib/src/generated/resolver.dart

+++ b/pkg/analyzer/lib/src/generated/resolver.dart

@@ -15101,7 +15101,7 @@ class StrongTypeSystemImpl implements TypeSystem {

// TODO(leafp): Document the rules in play here

@override

- bool isAssignableTo(DartType toType, DartType fromType) {

+ bool isAssignableTo(DartType fromType, DartType toType) {

Jennifer Messerly 2015/10/01 22:24:15 think of it as "fromType isAssignableTo toType"

// An actual subtype

if (isSubtypeOf(fromType, toType)) {

return true;

« no previous file with comments | « no previous file | pkg/analyzer/test/generated/type_system_test.dart » ('j') | no next file with comments »