Issue 1380963003: Preserve identity of Dart wrappers on DOM objects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1380963003: Preserve identity of Dart wrappers on DOM objects (Closed)

Created:
5 years, 2 months ago by Alan Knight

Modified:
5 years, 2 months ago

Reviewers:
Jacob

CC:
reviews_dartlang.org, ricow1

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Preserve identity of Dart wrappers on DOM objects BUG= Committed: https://github.com/dart-lang/sdk/commit/07b2ddd40142157f13e579d3e9294d4dcdf88473

Patch Set 1 #

Total comments: 2

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -12 lines)			Patch
M	sdk/lib/html/dartium/html_dartium.dart	View	3 chunks	+13 lines, -3 lines	1 comment	Download
M	sdk/lib/js/dartium/js_dartium.dart	View	1 chunk	+6 lines, -0 lines	1 comment	Download
M	tests/co19/co19-dartium.status	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	tests/html/html.status	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	tests/html/js_test.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	tools/dom/templates/html/dartium/html_dartium.darttemplate	View	2 chunks	+11 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Alan Knight

Committed patchset #1 (id:1) manually as 07b2ddd40142157f13e579d3e9294d4dcdf88473 (presubmit successful).

5 years, 2 months ago (2015-10-01 21:04:07 UTC) #1

Jacob

5 years, 2 months ago (2015-10-01 21:07:47 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/1380963003/diff/1/sdk/lib/html/dartium/html_d...
File sdk/lib/html/dartium/html_dartium.dart (right):

https://codereview.chromium.org/1380963003/diff/1/sdk/lib/html/dartium/html_d...
sdk/lib/html/dartium/html_dartium.dart:1158: +      return jsObject.dartWrapper;
change this to _dartWrapper and add a helper method with a unique name in
dart:js that gets it.

https://codereview.chromium.org/1380963003/diff/1/sdk/lib/js/dartium/js_darti...
File sdk/lib/js/dartium/js_dartium.dart (right):

https://codereview.chromium.org/1380963003/diff/1/sdk/lib/js/dartium/js_darti...
sdk/lib/js/dartium/js_dartium.dart:495: var wrapper;
this needs to be private

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages