Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1380953003: Fix Heap::ComputeHeapState after 057514 and 6256dc. (Closed)

Created:
5 years, 2 months ago by ulan
Modified:
5 years, 2 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix Heap::ComputeHeapState after 057514 and 6256dc. This restores size_of_objects and removed unused fields. BUG=chromium:538539 LOG=NO Committed: https://crrev.com/7549792863f1b33422f832fdab0e16eb6f87b761 Cr-Commit-Position: refs/heads/master@{#31072}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -18 lines) Patch
M src/heap/gc-idle-time-handler.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/heap/gc-idle-time-handler.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/unittests/heap/gc-idle-time-handler-unittest.cc View 4 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ulan
PTAL
5 years, 2 months ago (2015-10-02 12:20:47 UTC) #2
Michael Lippautz
lgtm
5 years, 2 months ago (2015-10-02 12:29:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380953003/1
5 years, 2 months ago (2015-10-02 12:34:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-02 12:58:25 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 12:58:48 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7549792863f1b33422f832fdab0e16eb6f87b761
Cr-Commit-Position: refs/heads/master@{#31072}

Powered by Google App Engine
This is Rietveld 408576698