Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1036)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1380893005: Enable testing of WebRTC IP Permission Finch (Closed)

Created:
5 years, 2 months ago by guoweis_left_chromium
Modified:
5 years, 2 months ago
Reviewers:
brettw, rkaplow
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable testing of WebRTC IP Permission Finch BUG=538815 Committed: https://crrev.com/efce5aa89bc5ac68f96184e44c4bb4b8c3a985e8 Cr-Commit-Position: refs/heads/master@{#352420}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M testing/variations/fieldtrial_testing_config_android.json View 1 chunk +5 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_chromeos.json View 1 chunk +5 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_linux.json View 1 chunk +5 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_mac.json View 1 chunk +5 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_win.json View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
guoweis_left_chromium
PTAL.
5 years, 2 months ago (2015-10-02 23:43:43 UTC) #2
rkaplow
lgtm
5 years, 2 months ago (2015-10-05 20:09:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380893005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380893005/1
5 years, 2 months ago (2015-10-05 20:14:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-05 20:57:17 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/efce5aa89bc5ac68f96184e44c4bb4b8c3a985e8 Cr-Commit-Position: refs/heads/master@{#352420}
5 years, 2 months ago (2015-10-05 20:57:57 UTC) #7
henrika (OOO until Aug 14)
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1388913002/ by henrika@chromium.org. ...
5 years, 2 months ago (2015-10-06 08:40:05 UTC) #8
guoweis_left_chromium
5 years, 2 months ago (2015-10-06 17:56:52 UTC) #9
Message was sent while issue was closed. 
mine is the culprit here. I'll reland this today after fixing the issue.

On Tue, Oct 6, 2015 at 1:40 AM, <henrika@chromium.org> wrote:

> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/1388913002/ by henrika@chromium.org.
>
> The reason for reverting is: Revert of Fixed the audio backgrounding bug
> (patchset #28 id:1220001 of https://codereview.chromium.org/1214883004/ )
>
> Reason for revert:
> Speculative revert since we see failing tests in the WebRTC waterfall
> related to
> ICE.
>
> See
>
>
>
https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester/builds/21950
>
>
https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/43969
> .
>
> https://codereview.chromium.org/1380893005/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698