Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1380883002: SubtreeStyleChange will propagate through <content>. (Closed)

Created:
5 years, 2 months ago by rune
Modified:
5 years, 2 months ago
Reviewers:
esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SubtreeStyleChange will propagate through <content>. No need to mark outer shadow hosts for style recalc when adding style elements with ::content rules because InsertionPoint::willRecalcStyle makes sure that distributed nodes and their descendants are recalculated. BUG=537480 Committed: https://crrev.com/d1edb4545251422ece58ee76bc2780849222e403 Cr-Commit-Position: refs/heads/master@{#351741}

Patch Set 1 #

Messages

Total messages: 11 (4 generated)
rune
5 years, 2 months ago (2015-09-30 19:33:34 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380883002/1
5 years, 2 months ago (2015-09-30 19:35:48 UTC) #4
esprehn
lgtm
5 years, 2 months ago (2015-09-30 19:54:23 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/120392)
5 years, 2 months ago (2015-09-30 21:15:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380883002/1
5 years, 2 months ago (2015-10-01 06:15:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-01 06:56:16 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 06:57:05 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d1edb4545251422ece58ee76bc2780849222e403
Cr-Commit-Position: refs/heads/master@{#351741}

Powered by Google App Engine
This is Rietveld 408576698