Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 1380873002: Merged fix for memory leak from glsl_lexer.ll (Closed)

Created:
5 years, 2 months ago by David Yen
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/mesa.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Merged fix for memory leak from glsl_lexer.ll Merged fix and regenerated glsl_lexer.cc using flex 2.5.39. R=kbr@chromium.org BUG=537004 Committed: https://chromium.googlesource.com/chromium/deps/mesa/+/a3dc7d623fbb83a6246adf3d363922ad3909c14c

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+267 lines, -253 lines) Patch
M chromium_gensrc/mesa/glsl_lexer.cc View 46 chunks +261 lines, -250 lines 3 comments Download
M src/glsl/glsl_lexer.ll View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
David Yen
5 years, 2 months ago (2015-09-30 19:13:15 UTC) #1
Ken Russell (switch to Gerrit)
lgtm https://chromiumcodereview.appspot.com/1380873002/diff/1/chromium_gensrc/mesa/glsl_lexer.cc File chromium_gensrc/mesa/glsl_lexer.cc (right): https://chromiumcodereview.appspot.com/1380873002/diff/1/chromium_gensrc/mesa/glsl_lexer.cc#newcode184 chromium_gensrc/mesa/glsl_lexer.cc:184: typedef size_t yy_size_t; Which version of flex/bison (or, ...
5 years, 2 months ago (2015-09-30 20:49:15 UTC) #2
David Yen
https://chromiumcodereview.appspot.com/1380873002/diff/1/chromium_gensrc/mesa/glsl_lexer.cc File chromium_gensrc/mesa/glsl_lexer.cc (right): https://chromiumcodereview.appspot.com/1380873002/diff/1/chromium_gensrc/mesa/glsl_lexer.cc#newcode184 chromium_gensrc/mesa/glsl_lexer.cc:184: typedef size_t yy_size_t; On 2015/09/30 20:49:15, Ken Russell wrote: ...
5 years, 2 months ago (2015-09-30 21:26:06 UTC) #3
David Yen
Committed patchset #1 (id:1) manually as a3dc7d623fbb83a6246adf3d363922ad3909c14c (presubmit successful).
5 years, 2 months ago (2015-09-30 21:26:51 UTC) #4
Ken Russell (switch to Gerrit)
5 years, 2 months ago (2015-09-30 21:28:01 UTC) #5
Message was sent while issue was closed.
https://chromiumcodereview.appspot.com/1380873002/diff/1/chromium_gensrc/mesa...
File chromium_gensrc/mesa/glsl_lexer.cc (right):

https://chromiumcodereview.appspot.com/1380873002/diff/1/chromium_gensrc/mesa...
chromium_gensrc/mesa/glsl_lexer.cc:184: typedef size_t yy_size_t;
On 2015/09/30 21:26:06, David Yen wrote:
> On 2015/09/30 20:49:15, Ken Russell wrote:
> > Which version of flex/bison (or, at least, which operating system and
version)
> > did you use to regenerate these files? Could you document that in one of the
> > READMEs? There are some boilerplate differences throughout this file now.
> 
> I included it in the README.chromium file and also in the CL description.

Thanks.

Powered by Google App Engine
This is Rietveld 408576698