Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Side by Side Diff: test/cctest/test-code-stubs-x64.cc

Issue 1380863004: Revert of Reland: Remove register index/code indirection (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Rrdistribution and use in source and binary forms, with or without 2 // Rrdistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Rrdistributions of source code must retain the above copyright 6 // * Rrdistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Rrdistributions in binary form must reproduce the above 8 // * Rrdistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 15 matching lines...) Expand all
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 #include <stdlib.h> 28 #include <stdlib.h>
29 29
30 #include "src/v8.h" 30 #include "src/v8.h"
31 31
32 #include "src/base/platform/platform.h" 32 #include "src/base/platform/platform.h"
33 #include "src/code-stubs.h" 33 #include "src/code-stubs.h"
34 #include "src/factory.h" 34 #include "src/factory.h"
35 #include "src/macro-assembler.h" 35 #include "src/macro-assembler.h"
36 #include "src/register-configuration.h"
37 #include "test/cctest/cctest.h" 36 #include "test/cctest/cctest.h"
38 #include "test/cctest/test-code-stubs.h" 37 #include "test/cctest/test-code-stubs.h"
39 38
40 using namespace v8::internal; 39 using namespace v8::internal;
41 40
42 41
43 #define __ assm. 42 #define __ assm.
44 43
45 ConvertDToIFunc MakeConvertDToIFuncTrampoline(Isolate* isolate, 44 ConvertDToIFunc MakeConvertDToIFuncTrampoline(Isolate* isolate,
46 Register source_reg, 45 Register source_reg,
47 Register destination_reg) { 46 Register destination_reg) {
48 // Allocate an executable page of memory. 47 // Allocate an executable page of memory.
49 size_t actual_size; 48 size_t actual_size;
50 byte* buffer = static_cast<byte*>(v8::base::OS::Allocate( 49 byte* buffer = static_cast<byte*>(v8::base::OS::Allocate(
51 Assembler::kMinimalBufferSize, &actual_size, true)); 50 Assembler::kMinimalBufferSize, &actual_size, true));
52 CHECK(buffer); 51 CHECK(buffer);
53 HandleScope handles(isolate); 52 HandleScope handles(isolate);
54 MacroAssembler assm(isolate, buffer, static_cast<int>(actual_size)); 53 MacroAssembler assm(isolate, buffer, static_cast<int>(actual_size));
55 int offset = 54 int offset =
56 source_reg.is(rsp) ? 0 : (HeapNumber::kValueOffset - kSmiTagSize); 55 source_reg.is(rsp) ? 0 : (HeapNumber::kValueOffset - kSmiTagSize);
57 DoubleToIStub stub(isolate, source_reg, destination_reg, offset, true); 56 DoubleToIStub stub(isolate, source_reg, destination_reg, offset, true);
58 byte* start = stub.GetCode()->instruction_start(); 57 byte* start = stub.GetCode()->instruction_start();
59 58
60 __ pushq(rbx); 59 __ pushq(rbx);
61 __ pushq(rcx); 60 __ pushq(rcx);
62 __ pushq(rdx); 61 __ pushq(rdx);
63 __ pushq(rsi); 62 __ pushq(rsi);
64 __ pushq(rdi); 63 __ pushq(rdi);
65 64
66
67 const RegisterConfiguration* config = RegisterConfiguration::ArchDefault();
68 if (!source_reg.is(rsp)) { 65 if (!source_reg.is(rsp)) {
69 // The argument we pass to the stub is not a heap number, but instead 66 // The argument we pass to the stub is not a heap number, but instead
70 // stack-allocated and offset-wise made to look like a heap number for 67 // stack-allocated and offset-wise made to look like a heap number for
71 // the stub. We create that "heap number" after pushing all allocatable 68 // the stub. We create that "heap number" after pushing all allocatable
72 // registers. 69 // registers.
73 int double_argument_slot = 70 int double_argument_slot =
74 (config->num_allocatable_general_registers() - 1) * kPointerSize + 71 (Register::NumAllocatableRegisters() - 1) * kPointerSize + kDoubleSize;
75 kDoubleSize;
76 __ leaq(source_reg, MemOperand(rsp, -double_argument_slot - offset)); 72 __ leaq(source_reg, MemOperand(rsp, -double_argument_slot - offset));
77 } 73 }
78 74
79 // Save registers make sure they don't get clobbered. 75 // Save registers make sure they don't get clobbered.
80 int reg_num = 0; 76 int reg_num = 0;
81 for (; reg_num < config->num_allocatable_general_registers(); ++reg_num) { 77 for (; reg_num < Register::NumAllocatableRegisters(); ++reg_num) {
82 Register reg = 78 Register reg = Register::FromAllocationIndex(reg_num);
83 Register::from_code(config->GetAllocatableGeneralCode(reg_num));
84 if (!reg.is(rsp) && !reg.is(rbp) && !reg.is(destination_reg)) { 79 if (!reg.is(rsp) && !reg.is(rbp) && !reg.is(destination_reg)) {
85 __ pushq(reg); 80 __ pushq(reg);
86 } 81 }
87 } 82 }
88 83
89 // Put the double argument into the designated double argument slot. 84 // Put the double argument into the designated double argument slot.
90 __ subq(rsp, Immediate(kDoubleSize)); 85 __ subq(rsp, Immediate(kDoubleSize));
91 __ movsd(MemOperand(rsp, 0), xmm0); 86 __ movsd(MemOperand(rsp, 0), xmm0);
92 87
93 // Call through to the actual stub 88 // Call through to the actual stub
94 __ Call(start, RelocInfo::EXTERNAL_REFERENCE); 89 __ Call(start, RelocInfo::EXTERNAL_REFERENCE);
95 90
96 __ addq(rsp, Immediate(kDoubleSize)); 91 __ addq(rsp, Immediate(kDoubleSize));
97 92
98 // Make sure no registers have been unexpectedly clobbered 93 // Make sure no registers have been unexpectedly clobbered
99 for (--reg_num; reg_num >= 0; --reg_num) { 94 for (--reg_num; reg_num >= 0; --reg_num) {
100 Register reg = 95 Register reg = Register::FromAllocationIndex(reg_num);
101 Register::from_code(config->GetAllocatableGeneralCode(reg_num));
102 if (!reg.is(rsp) && !reg.is(rbp) && !reg.is(destination_reg)) { 96 if (!reg.is(rsp) && !reg.is(rbp) && !reg.is(destination_reg)) {
103 __ cmpq(reg, MemOperand(rsp, 0)); 97 __ cmpq(reg, MemOperand(rsp, 0));
104 __ Assert(equal, kRegisterWasClobbered); 98 __ Assert(equal, kRegisterWasClobbered);
105 __ addq(rsp, Immediate(kPointerSize)); 99 __ addq(rsp, Immediate(kPointerSize));
106 } 100 }
107 } 101 }
108 102
109 __ movq(rax, destination_reg); 103 __ movq(rax, destination_reg);
110 104
111 __ popq(rdi); 105 __ popq(rdi);
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 142
149 for (size_t s = 0; s < sizeof(source_registers) / sizeof(Register); s++) { 143 for (size_t s = 0; s < sizeof(source_registers) / sizeof(Register); s++) {
150 for (size_t d = 0; d < sizeof(dest_registers) / sizeof(Register); d++) { 144 for (size_t d = 0; d < sizeof(dest_registers) / sizeof(Register); d++) {
151 RunAllTruncationTests( 145 RunAllTruncationTests(
152 MakeConvertDToIFuncTrampoline(isolate, 146 MakeConvertDToIFuncTrampoline(isolate,
153 source_registers[s], 147 source_registers[s],
154 dest_registers[d])); 148 dest_registers[d]));
155 } 149 }
156 } 150 }
157 } 151 }
OLDNEW
« no previous file with comments | « test/cctest/test-code-stubs-mips64.cc ('k') | test/unittests/compiler/instruction-selector-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698