Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Side by Side Diff: src/mips/macro-assembler-mips.cc

Issue 1380863004: Revert of Reland: Remove register index/code indirection (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips/macro-assembler-mips.h ('k') | src/mips64/assembler-mips64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 1
2 // Copyright 2012 the V8 project authors. All rights reserved. 2 // Copyright 2012 the V8 project authors. All rights reserved.
3 // Use of this source code is governed by a BSD-style license that can be 3 // Use of this source code is governed by a BSD-style license that can be
4 // found in the LICENSE file. 4 // found in the LICENSE file.
5 5
6 #include <limits.h> // For LONG_MIN, LONG_MAX. 6 #include <limits.h> // For LONG_MIN, LONG_MAX.
7 7
8 #if V8_TARGET_ARCH_MIPS 8 #if V8_TARGET_ARCH_MIPS
9 9
10 #include "src/base/bits.h" 10 #include "src/base/bits.h"
11 #include "src/base/division-by-constant.h" 11 #include "src/base/division-by-constant.h"
12 #include "src/bootstrapper.h" 12 #include "src/bootstrapper.h"
13 #include "src/codegen.h" 13 #include "src/codegen.h"
14 #include "src/debug/debug.h" 14 #include "src/debug/debug.h"
15 #include "src/mips/macro-assembler-mips.h" 15 #include "src/mips/macro-assembler-mips.h"
16 #include "src/register-configuration.h"
17 #include "src/runtime/runtime.h" 16 #include "src/runtime/runtime.h"
18 17
19 namespace v8 { 18 namespace v8 {
20 namespace internal { 19 namespace internal {
21 20
22 MacroAssembler::MacroAssembler(Isolate* arg_isolate, void* buffer, int size) 21 MacroAssembler::MacroAssembler(Isolate* arg_isolate, void* buffer, int size)
23 : Assembler(arg_isolate, buffer, size), 22 : Assembler(arg_isolate, buffer, size),
24 generating_stub_(false), 23 generating_stub_(false),
25 has_frame_(false), 24 has_frame_(false),
26 has_double_zero_reg_set_(false) { 25 has_double_zero_reg_set_(false) {
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 139
141 140
142 MemOperand MacroAssembler::SafepointRegisterSlot(Register reg) { 141 MemOperand MacroAssembler::SafepointRegisterSlot(Register reg) {
143 return MemOperand(sp, SafepointRegisterStackIndex(reg.code()) * kPointerSize); 142 return MemOperand(sp, SafepointRegisterStackIndex(reg.code()) * kPointerSize);
144 } 143 }
145 144
146 145
147 MemOperand MacroAssembler::SafepointRegistersAndDoublesSlot(Register reg) { 146 MemOperand MacroAssembler::SafepointRegistersAndDoublesSlot(Register reg) {
148 UNIMPLEMENTED_MIPS(); 147 UNIMPLEMENTED_MIPS();
149 // General purpose registers are pushed last on the stack. 148 // General purpose registers are pushed last on the stack.
150 int doubles_size = DoubleRegister::kMaxNumRegisters * kDoubleSize; 149 int doubles_size = FPURegister::NumAllocatableRegisters() * kDoubleSize;
151 int register_offset = SafepointRegisterStackIndex(reg.code()) * kPointerSize; 150 int register_offset = SafepointRegisterStackIndex(reg.code()) * kPointerSize;
152 return MemOperand(sp, doubles_size + register_offset); 151 return MemOperand(sp, doubles_size + register_offset);
153 } 152 }
154 153
155 154
156 void MacroAssembler::InNewSpace(Register object, 155 void MacroAssembler::InNewSpace(Register object,
157 Register scratch, 156 Register scratch,
158 Condition cc, 157 Condition cc,
159 Label* branch) { 158 Label* branch) {
160 DCHECK(cc == eq || cc == ne); 159 DCHECK(cc == eq || cc == ne);
(...skipping 3514 matching lines...) Expand 10 before | Expand all | Expand 10 after
3675 RegList temps, 3674 RegList temps,
3676 int field_count) { 3675 int field_count) {
3677 DCHECK((temps & dst.bit()) == 0); 3676 DCHECK((temps & dst.bit()) == 0);
3678 DCHECK((temps & src.bit()) == 0); 3677 DCHECK((temps & src.bit()) == 0);
3679 // Primitive implementation using only one temporary register. 3678 // Primitive implementation using only one temporary register.
3680 3679
3681 Register tmp = no_reg; 3680 Register tmp = no_reg;
3682 // Find a temp register in temps list. 3681 // Find a temp register in temps list.
3683 for (int i = 0; i < kNumRegisters; i++) { 3682 for (int i = 0; i < kNumRegisters; i++) {
3684 if ((temps & (1 << i)) != 0) { 3683 if ((temps & (1 << i)) != 0) {
3685 tmp.reg_code = i; 3684 tmp.code_ = i;
3686 break; 3685 break;
3687 } 3686 }
3688 } 3687 }
3689 DCHECK(!tmp.is(no_reg)); 3688 DCHECK(!tmp.is(no_reg));
3690 3689
3691 for (int i = 0; i < field_count; i++) { 3690 for (int i = 0; i < field_count; i++) {
3692 lw(tmp, FieldMemOperand(src, i * kPointerSize)); 3691 lw(tmp, FieldMemOperand(src, i * kPointerSize));
3693 sw(tmp, FieldMemOperand(dst, i * kPointerSize)); 3692 sw(tmp, FieldMemOperand(dst, i * kPointerSize));
3694 } 3693 }
3695 } 3694 }
(...skipping 2076 matching lines...) Expand 10 before | Expand all | Expand 10 after
5772 Register reg5, 5771 Register reg5,
5773 Register reg6) { 5772 Register reg6) {
5774 RegList regs = 0; 5773 RegList regs = 0;
5775 if (reg1.is_valid()) regs |= reg1.bit(); 5774 if (reg1.is_valid()) regs |= reg1.bit();
5776 if (reg2.is_valid()) regs |= reg2.bit(); 5775 if (reg2.is_valid()) regs |= reg2.bit();
5777 if (reg3.is_valid()) regs |= reg3.bit(); 5776 if (reg3.is_valid()) regs |= reg3.bit();
5778 if (reg4.is_valid()) regs |= reg4.bit(); 5777 if (reg4.is_valid()) regs |= reg4.bit();
5779 if (reg5.is_valid()) regs |= reg5.bit(); 5778 if (reg5.is_valid()) regs |= reg5.bit();
5780 if (reg6.is_valid()) regs |= reg6.bit(); 5779 if (reg6.is_valid()) regs |= reg6.bit();
5781 5780
5782 const RegisterConfiguration* config = RegisterConfiguration::ArchDefault(); 5781 for (int i = 0; i < Register::NumAllocatableRegisters(); i++) {
5783 for (int i = 0; i < config->num_allocatable_general_registers(); ++i) { 5782 Register candidate = Register::FromAllocationIndex(i);
5784 int code = config->GetAllocatableGeneralCode(i);
5785 Register candidate = Register::from_code(code);
5786 if (regs & candidate.bit()) continue; 5783 if (regs & candidate.bit()) continue;
5787 return candidate; 5784 return candidate;
5788 } 5785 }
5789 UNREACHABLE(); 5786 UNREACHABLE();
5790 return no_reg; 5787 return no_reg;
5791 } 5788 }
5792 5789
5793 5790
5794 void MacroAssembler::JumpIfDictionaryInPrototypeChain( 5791 void MacroAssembler::JumpIfDictionaryInPrototypeChain(
5795 Register object, 5792 Register object,
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
5929 if (mag.shift > 0) sra(result, result, mag.shift); 5926 if (mag.shift > 0) sra(result, result, mag.shift);
5930 srl(at, dividend, 31); 5927 srl(at, dividend, 31);
5931 Addu(result, result, Operand(at)); 5928 Addu(result, result, Operand(at));
5932 } 5929 }
5933 5930
5934 5931
5935 } // namespace internal 5932 } // namespace internal
5936 } // namespace v8 5933 } // namespace v8
5937 5934
5938 #endif // V8_TARGET_ARCH_MIPS 5935 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/mips/macro-assembler-mips.h ('k') | src/mips64/assembler-mips64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698