Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1380763003: [iOS] Integration of ChromeNetLog and NetExportUI (Closed)

Created:
5 years, 2 months ago by droger
Modified:
5 years, 2 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Integration of ChromeNetLog and NetExportUI Committed: https://crrev.com/130d7b253e6bdc411ce74c7a712f0e04cbbc9692 Cr-Commit-Position: refs/heads/master@{#352013}

Patch Set 1 #

Patch Set 2 : Cleanup whitelist #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -90 lines) Patch
M build/ios/grit_whitelist.txt View 1 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -10 lines 0 comments Download
M ios/chrome/app/strings/ios_strings.grd View 1 chunk +9 lines, -0 lines 0 comments Download
M ios/chrome/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/application_context.h View 2 chunks +8 lines, -1 line 0 comments Download
M ios/chrome/browser/application_context_impl.h View 2 chunks +8 lines, -1 line 0 comments Download
M ios/chrome/browser/application_context_impl.cc View 2 chunks +15 lines, -1 line 0 comments Download
M ios/chrome/browser/chrome_url_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/chrome_url_constants.cc View 1 chunk +1 line, -0 lines 0 comments Download
A + ios/chrome/browser/ui/webui/net_export/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A ios/chrome/browser/ui/webui/net_export/net_export_ui.h View 1 chunk +20 lines, -0 lines 0 comments Download
A + ios/chrome/browser/ui/webui/net_export/net_export_ui.cc View 10 chunks +57 lines, -73 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 2 chunks +3 lines, -0 lines 0 comments Download
M ios/chrome/test/testing_application_context.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/test/testing_application_context.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
droger
5 years, 2 months ago (2015-10-02 11:38:47 UTC) #2
sdefresne
lgtm
5 years, 2 months ago (2015-10-02 12:27:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380763003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380763003/20001
5 years, 2 months ago (2015-10-02 12:54:00 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-02 13:00:15 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 13:01:13 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/130d7b253e6bdc411ce74c7a712f0e04cbbc9692
Cr-Commit-Position: refs/heads/master@{#352013}

Powered by Google App Engine
This is Rietveld 408576698