Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Issue 1380733002: Refine FilterEffect::createTransparentBlack (Closed)

Created:
5 years, 2 months ago by fs
Modified:
5 years, 2 months ago
Reviewers:
Stephen White
CC:
fs, blink-reviews, Rik, chromium-reviews, danakj, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), gyuyoung2, jbroman, Justin Novosad, kouhei+svg_chromium.org, pdr+graphicswatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refine FilterEffect::createTransparentBlack Use an image filter that will produce a region of pixels rather than one that won't. Fixes issue with feConvolveMatrix error handling with -webkit-filter. BUG=533457 Committed: https://crrev.com/eb684ee648153e593d4ace3e0eb4612b205d29f0 Cr-Commit-Position: refs/heads/master@{#351658}

Patch Set 1 #

Messages

Total messages: 7 (2 generated)
fs
5 years, 2 months ago (2015-09-30 12:26:33 UTC) #2
Stephen White
LGTM
5 years, 2 months ago (2015-09-30 18:20:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380733002/1
5 years, 2 months ago (2015-09-30 22:06:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-30 22:15:26 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 22:17:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb684ee648153e593d4ace3e0eb4612b205d29f0
Cr-Commit-Position: refs/heads/master@{#351658}

Powered by Google App Engine
This is Rietveld 408576698