Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: chrome/browser/chromeos/drive/resource_metadata_unittest.cc

Issue 138073010: drive: Add resource ID duplication check to ResourceMetadata::RefreshEntry (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix test Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/drive/resource_metadata.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/drive/resource_metadata_unittest.cc
diff --git a/chrome/browser/chromeos/drive/resource_metadata_unittest.cc b/chrome/browser/chromeos/drive/resource_metadata_unittest.cc
index 497d7157697dbaf88810faaf8ddcc8d10975c7df..c05b9157cb5f0602b11982de824aceb9c313dfd2 100644
--- a/chrome/browser/chromeos/drive/resource_metadata_unittest.cc
+++ b/chrome/browser/chromeos/drive/resource_metadata_unittest.cc
@@ -424,6 +424,27 @@ TEST_F(ResourceMetadataTest, RefreshEntry) {
resource_metadata_->RefreshEntry(dir_entry));
}
+TEST_F(ResourceMetadataTest, RefreshEntry_ResourceIDCheck) {
+ // Get an entry with a non-empty resource ID.
+ ResourceEntry entry;
+ EXPECT_EQ(FILE_ERROR_OK, resource_metadata_->GetResourceEntryByPath(
+ base::FilePath::FromUTF8Unsafe("drive/root/dir1"), &entry));
+ EXPECT_FALSE(entry.resource_id().empty());
+
+ // Add a new entry with an empty resource ID.
+ ResourceEntry new_entry;
+ new_entry.set_parent_local_id(entry.local_id());
+ new_entry.set_title("new entry");
+ std::string local_id;
+ EXPECT_EQ(FILE_ERROR_OK, resource_metadata_->AddEntry(new_entry, &local_id));
+
+ // Try to refresh the new entry with a used resource ID.
+ new_entry.set_local_id(local_id);
+ new_entry.set_resource_id(entry.resource_id());
+ EXPECT_EQ(FILE_ERROR_INVALID_OPERATION,
+ resource_metadata_->RefreshEntry(new_entry));
+}
+
TEST_F(ResourceMetadataTest, GetSubDirectoriesRecursively) {
std::set<base::FilePath> sub_directories;
« no previous file with comments | « chrome/browser/chromeos/drive/resource_metadata.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698