Issue 138073004: Fix omnibox height when less than 64 pixels tall.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 138073004: Fix omnibox height when less than 64 pixels tall. (Closed)

Created:
6 years, 11 months ago by jbauman

Modified:
6 years, 11 months ago

Reviewers:
ananta, Ben Goodger (Google)

CC:
chromium-reviews, sadrul, ben+views_chromium.org, ben+aura_chromium.org, tfarina, kalyank

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix omnibox height when less than 64 pixels tall. Ensure there's always a HandleClientSizeChanged call that happens when the bounds change (even if that doesn't cause the actual bounds of the HWND to change), as otherwise the view size will be stale. BUG=330123 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245156

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -24 lines)			Patch
M	ui/aura/window_tree_host.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	ui/views/widget/desktop_aura/desktop_root_window_host_win.cc	View		4 chunks	+16 lines, -11 lines	0 comments	Download
M	ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/views/win/hwnd_message_handler.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/views/win/hwnd_message_handler.cc	View		2 chunks	+9 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jbauman

ben@, could you take a look at this again? It's essentially https://codereview.chromium.org/123793002/ but with a ...

6 years, 11 months ago (2014-01-15 00:46:45 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/138073004/40001

6 years, 11 months ago (2014-01-15 21:29:30 UTC) #3

Message was sent while issue was closed.

Change committed as 245156

Expand Messages | Collapse Messages