Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: components/sync_driver/invalidation_helper.cc

Issue 1380693004: [Sync] Fixing sync_driver lint violations and adding PRESUBMIT lint check. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cross
Patch Set: Removing lint fixes for revisit files, removing revisit patch dep. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/sync_driver/invalidation_helper.h" 5 #include "components/sync_driver/invalidation_helper.h"
6 6
7 #include <string>
8
7 #include "google/cacheinvalidation/types.pb.h" 9 #include "google/cacheinvalidation/types.pb.h"
8 10
9 namespace syncer { 11 namespace syncer {
10 12
11 bool RealModelTypeToObjectId(ModelType model_type, 13 bool RealModelTypeToObjectId(ModelType model_type,
12 invalidation::ObjectId* object_id) { 14 invalidation::ObjectId* object_id) {
13 std::string notification_type; 15 std::string notification_type;
14 if (!RealModelTypeToNotificationType(model_type, &notification_type)) { 16 if (!RealModelTypeToNotificationType(model_type, &notification_type)) {
15 return false; 17 return false;
16 } 18 }
17 object_id->Init(ipc::invalidation::ObjectSource::CHROME_SYNC, 19 object_id->Init(ipc::invalidation::ObjectSource::CHROME_SYNC,
18 notification_type); 20 notification_type);
19 return true; 21 return true;
20 } 22 }
21 23
22 ObjectIdSet ModelTypeSetToObjectIdSet(ModelTypeSet model_types) { 24 ObjectIdSet ModelTypeSetToObjectIdSet(ModelTypeSet model_types) {
23 ObjectIdSet ids; 25 ObjectIdSet ids;
24 for (ModelTypeSet::Iterator it = model_types.First(); it.Good(); it.Inc()) { 26 for (ModelTypeSet::Iterator it = model_types.First(); it.Good(); it.Inc()) {
25 invalidation::ObjectId model_type_as_id; 27 invalidation::ObjectId model_type_as_id;
26 if (!RealModelTypeToObjectId(it.Get(), &model_type_as_id)) { 28 if (!RealModelTypeToObjectId(it.Get(), &model_type_as_id)) {
27 DLOG(WARNING) << "Invalid model type " << it.Get(); 29 DLOG(WARNING) << "Invalid model type " << it.Get();
28 continue; 30 continue;
29 } 31 }
30 ids.insert(model_type_as_id); 32 ids.insert(model_type_as_id);
31 } 33 }
32 return ids; 34 return ids;
33 } 35 }
34 36
35 } // namespace syncer 37 } // namespace syncer
OLDNEW
« no previous file with comments | « components/sync_driver/invalidation_adapter.h ('k') | components/sync_driver/local_device_info_provider_mock.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698