Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 1380663004: Revert "aw: Disable ipc command buffer by default" (Closed)

Created:
5 years, 2 months ago by boliu
Modified:
5 years, 2 months ago
Reviewers:
hush (inactive)
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "aw: Disable ipc command buffer by default" Re-enable ipc based command buffer after fix for IO thread blocking in r351894 BUG=509702 Committed: https://crrev.com/8a3a10e0cd0b1f893ff1bb3f577c18c93702c978 Cr-Commit-Position: refs/heads/master@{#351928}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M android_webview/browser/aw_browser_main_parts.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M android_webview/common/aw_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/common/aw_switches.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/lib/main/aw_main_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
boliu
err, just sending this through cq now
5 years, 2 months ago (2015-10-02 00:58:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380663004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380663004/1
5 years, 2 months ago (2015-10-02 00:58:51 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/90653) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, ...
5 years, 2 months ago (2015-10-02 01:03:59 UTC) #5
hush (inactive)
lgtm
5 years, 2 months ago (2015-10-02 01:05:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380663004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380663004/1
5 years, 2 months ago (2015-10-02 01:20:10 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-02 01:35:05 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 01:36:44 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a3a10e0cd0b1f893ff1bb3f577c18c93702c978
Cr-Commit-Position: refs/heads/master@{#351928}

Powered by Google App Engine
This is Rietveld 408576698