Mac Overlays: Allow SolidColor and Tile quads to be candidates for overlays.

cc/layers/picture_layer_impl.cc

Index: cc/layers/picture_layer_impl.cc
diff --git a/cc/layers/picture_layer_impl.cc b/cc/layers/picture_layer_impl.cc
index a550968e69fdfeb03681cda1adb7d864c1620fb2..b615c8aa3aaca737205dbac15c2a27de99fbd8d3 100644
--- a/cc/layers/picture_layer_impl.cc
+++ b/cc/layers/picture_layer_impl.cc
@@ -303,12 +303,16 @@ void PictureLayerImpl::AppendQuads(RenderPass* render_pass,
             append_quads_data->num_incomplete_tiles++;
           }
 
+          ResourceProvider::ScopedReadLockGpuMemoryBuffer lock(
+              layer_tree_impl()->resource_provider(), draw_info.resource_id());

[Andre, 2015/10/02 18:10:15]

Here we want allow_overlay to be set if the resource has a GLImage.
I created ScopedReadLockGpuMemoryBuffer but not sure if it's right.
Seems like it should call ResourceProvider:;LockForRead(), but if I do that I
hit this exported_count assert.
https://code.google.com/p/chromium/codesearch#chromium/src/cc/resources/resou...

Daniele, WDYT?

+
           TileDrawQuad* quad =
               render_pass->CreateAndAppendDrawQuad<TileDrawQuad>();
           quad->SetNew(shared_quad_state, geometry_rect, opaque_rect,
                        visible_geometry_rect, draw_info.resource_id(),
                        texture_rect, draw_info.resource_size(),
-                       draw_info.contents_swizzled(), nearest_neighbor_);
+                       draw_info.contents_swizzled(), nearest_neighbor_,
+                       lock.image_id() != 0);
           ValidateQuadResources(quad);
           iter->draw_info().set_was_ever_used_to_draw();
           has_draw_quad = true;