third_party/WebKit/LayoutTests/printing/webgl-oversized-printing.html - Issue 1380633003: Fixed WebGL printing crash due to failed buffer allocation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/printing/webgl-oversized-printing.html

Issue 1380633003: Fixed WebGL printing crash due to failed buffer allocation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/printing/webgl-oversized-printing-expected.txt » ('j') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!-- This is a regression test for crbug.com/537711, in which printing

	2 was causing a crash on the main thread of the render process -->

	3 <head>

	4 <script src="../resources/js-test.js"></script>

	5 </head>

	6 <body>

	7 <div id="console"></div>

	8 <script>

	9 var can = document.createElement('canvas');

	10 can.width = can.height = 100000; // Too large to allocate because width*height o verflows uint32

	11 document.body.appendChild(can);

	12 var ctx = can.getContext("webgl");

	13 ctx.clearColor(0, 0, 0, 0);
	Ken Russell (switch to Gerrit) 2015/10/01 02:33:30 Can you call ctx.clear(ctx.COLOR_BUFFER_BIT) here Can you call ctx.clear(ctx.COLOR_BUFFER_BIT) here to get the markContextChanged method to be called?
	14

	15 if (!window.testRunner) {

	16 testFailed("Requires window.testRunner");

	17 } else {

	18 testRunner.setPrinting();

	19 testRunner.waitUntilDone();

	20 testRunner.capturePixelsAsyncThen(function() {

	21 testRunner.clearPrinting();

	22 testPassed("Printed without crashing.");

	23 testRunner.notifyDone();

	24 });

	25 }

	26 </script>

	27 </body>

OLD	NEW