Issue 138063006: Make the type argument to HTMLMediaElement.canPlayType non-optional

Issue 138063006: Make the type argument to HTMLMediaElement.canPlayType non-optional (Closed)

Created:
6 years, 11 months ago by philipj_slow

Modified:
6 years, 11 months ago

Reviewers:
acolwell GONE FROM CHROMIUM

CC:
blink-reviews, nessy, arv+blink, philipj_slow, gasubic, vcarbune.chromium, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Make the type argument to HTMLMediaElement.canPlayType non-optional http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#htmlmediaelement Ad-hoc testing shows that it is also non-optional in Firefox Nightly, IE11 and Opera 12.16. BUG=334660 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165153

Patch Set 1 #

Patch Set 2 : remove redundant failing test #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -8 lines)			Patch
M	LayoutTests/media/encrypted-media/encrypted-media-can-play-type.html	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	LayoutTests/media/encrypted-media/encrypted-media-can-play-type-expected.txt	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	LayoutTests/media/media-can-play-type.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/media/media-can-play-type-expected.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/HTMLMediaElement.idl	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/138063006/1

6 years, 11 months ago (2014-01-15 16:29:57 UTC) #3

commit-bot: I haz the power

Failed to trigger a try job on linux_blink_rel HTTP Error 400: Bad Request

6 years, 11 months ago (2014-01-15 16:51:33 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/138063006/80001

6 years, 11 months ago (2014-01-15 16:51:46 UTC) #5

Message was sent while issue was closed.

Change committed as 165153

Expand Messages | Collapse Messages