Serialization of SkPictureImageFilter

samplecode/SampleFilterFuzz.cpp

 /*
  * Copyright 2013 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 #include "SampleCode.h"
 #include "SkBicubicImageFilter.h"
 #include "SkBitmapDevice.h"
 #include "SkBitmapSource.h"
@@ skipping 241 matching lines @@
         break;
     case MORPHOLOGY:
         if (R(2) == 1)
             filter = new SkDilateImageFilter(R(static_cast<float>(kBitmapSize)),
                 R(static_cast<float>(kBitmapSize)), make_image_filter());
         else
             filter = new SkErodeImageFilter(R(static_cast<float>(kBitmapSize)),
                 R(static_cast<float>(kBitmapSize)), make_image_filter());
         break;
     case BITMAP:
-        filter = new SkBitmapSource(make_bitmap());
+        filter = new SkBitmapSource(make_bitmap(), make_rect(), make_rect());

[Stephen White, 2014/01/15 14:59:02]

This should probably be landed separately from this change.

We should also exercise the other (1-parameter) constructor as well, in order to
get full coverage. Perhaps 50% randomly.

[sugoi, 2014/01/15 16:49:22]

Done. (see https://codereview.chromium.org/139613002/)

         break;
     case DISPLACE:
         filter = new SkDisplacementMapEffect(make_channel_selector_type(),
                      make_channel_selector_type(), make_scalar(),
                      make_image_filter(false), make_image_filter());
         break;
     case TILE:
         filter = new SkTileImageFilter(make_rect(), make_rect(), make_image_filter(false));
         break;
     default:
@@ skipping 92 matching lines @@
     }
 
 private:
     typedef SkView INHERITED;
 };
 
 //////////////////////////////////////////////////////////////////////////////
 
 static SkView* MyFactory() { return new ImageFilterFuzzView; }
 static SkViewRegister reg(MyFactory);