Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1380593002: [swarming] Isolate v8 testing. (Closed)

Created:
5 years, 2 months ago by Michael Achenbach
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com, M-A Ruel
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[swarming] Isolate v8 testing. Add gyp support and isolates for default test suites. Add two default isolates, one (default) for using the test suite collection we call "default" on the bots. One (developer_default) for also supporting the way developers call the driver (i.e. without argument, which includes the unittests). BUG=chromium:535160 LOG=n Committed: https://crrev.com/9bd83f58f29ab0c7c5b71b00bcb1df3a9e641f05 Cr-Commit-Position: refs/heads/master@{#31081}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : Adding more test suites. #

Patch Set 6 : More tests #

Patch Set 7 : Improve dependencies. #

Patch Set 8 : Make dependencies conditional. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+258 lines, -44 lines) Patch
M build/all.gyp View 1 2 3 4 5 6 7 1 chunk +10 lines, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 2 3 4 1 chunk +19 lines, -0 lines 0 comments Download
A + test/cctest/cctest.isolate View 1 2 3 4 1 chunk +5 lines, -5 lines 0 comments Download
A test/default.gyp View 1 2 3 4 5 1 chunk +29 lines, -0 lines 0 comments Download
A + test/default.isolate View 1 2 3 4 5 1 chunk +5 lines, -9 lines 0 comments Download
A test/developer_default.gyp View 1 2 3 4 5 6 1 chunk +26 lines, -0 lines 0 comments Download
A + test/developer_default.isolate View 1 2 3 4 5 6 1 chunk +6 lines, -5 lines 0 comments Download
A test/intl/intl.gyp View 1 2 3 4 5 1 chunk +25 lines, -0 lines 0 comments Download
A + test/intl/intl.isolate View 1 2 3 4 5 1 chunk +3 lines, -5 lines 0 comments Download
A test/message/message.gyp View 1 2 3 4 1 chunk +25 lines, -0 lines 0 comments Download
A + test/message/message.isolate View 1 2 3 4 1 chunk +3 lines, -5 lines 0 comments Download
A test/mjsunit/mjsunit.gyp View 1 2 3 4 1 chunk +25 lines, -0 lines 0 comments Download
A test/mjsunit/mjsunit.isolate View 1 1 chunk +23 lines, -0 lines 0 comments Download
A test/preparser/preparser.gyp View 1 2 3 4 1 chunk +25 lines, -0 lines 0 comments Download
A + test/preparser/preparser.isolate View 1 2 3 4 1 chunk +3 lines, -5 lines 0 comments Download
M test/unittests/unittests.gyp View 1 2 3 4 5 1 chunk +19 lines, -0 lines 0 comments Download
A + test/unittests/unittests.isolate View 1 2 3 4 5 1 chunk +4 lines, -5 lines 0 comments Download
A + tools/testrunner/testrunner.isolate View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
Michael Achenbach
PTAL. tandrii for isolate stuff, jochen for v8-specific stuff Tested locally with: GYP_GENERATORS=ninja GYP_DEFINES="target_arch=x64 v8_target_arch=x64 ...
5 years, 2 months ago (2015-10-02 12:24:56 UTC) #2
M-A Ruel
rubberstamp lgtm
5 years, 2 months ago (2015-10-02 12:34:16 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380593002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380593002/120001
5 years, 2 months ago (2015-10-02 12:52:13 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/8403)
5 years, 2 months ago (2015-10-02 12:55:39 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380593002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380593002/140001
5 years, 2 months ago (2015-10-02 13:06:29 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-02 13:40:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380593002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380593002/140001
5 years, 2 months ago (2015-10-02 15:06:38 UTC) #15
commit-bot: I haz the power
Committed patchset #8 (id:140001)
5 years, 2 months ago (2015-10-02 15:15:35 UTC) #16
commit-bot: I haz the power
Patchset 8 (id:??) landed as https://crrev.com/9bd83f58f29ab0c7c5b71b00bcb1df3a9e641f05 Cr-Commit-Position: refs/heads/master@{#31081}
5 years, 2 months ago (2015-10-02 15:15:46 UTC) #17
danno
A revert of this CL (patchset #8 id:140001) has been created in https://codereview.chromium.org/1370993008/ by danno@chromium.org. ...
5 years, 2 months ago (2015-10-02 15:44:34 UTC) #18
danno
5 years, 2 months ago (2015-10-02 15:45:58 UTC) #19
Message was sent while issue was closed.
A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/1386663002/ by danno@chromium.org.

The reason for reverting is: Prime suspect for breaking Linux V8 - no snap.

Powered by Google App Engine
This is Rietveld 408576698