Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1789)

Unified Diff: content/browser/renderer_host/render_view_host_impl.h

Issue 1380573003: Remove 2-stage RenderWidget initialization (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix racy test Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_view_host_impl.h
diff --git a/content/browser/renderer_host/render_view_host_impl.h b/content/browser/renderer_host/render_view_host_impl.h
index e08efc95fe34a06a17fb5cf2c9926c49e8b8a9a3..59a104ab7923a76d8e082c74498b7695535c4173 100644
--- a/content/browser/renderer_host/render_view_host_impl.h
+++ b/content/browser/renderer_host/render_view_host_impl.h
@@ -185,6 +185,7 @@ class CONTENT_EXPORT RenderViewHostImpl
#endif
// RenderProcessHostObserver implementation
+ void RenderProcessReady(RenderProcessHost* host) override;
void RenderProcessExited(RenderProcessHost* host,
base::TerminationStatus status,
int exit_code) override;
@@ -349,7 +350,6 @@ class CONTENT_EXPORT RenderViewHostImpl
bool user_gesture);
void OnShowWidget(int route_id, const gfx::Rect& initial_rect);
void OnShowFullscreenWidget(int route_id);
- void OnRenderViewReady();
void OnRenderProcessGone(int status, int error_code);
void OnUpdateState(int32 page_id, const PageState& state);
void OnUpdateTargetURL(const GURL& url);
@@ -384,6 +384,10 @@ class CONTENT_EXPORT RenderViewHostImpl
FRIEND_TEST_ALL_PREFIXES(RenderViewHostTest, RoutingIdSane);
FRIEND_TEST_ALL_PREFIXES(RenderFrameHostManagerTest,
CleanUpSwappedOutRVHOnProcessCrash);
+ // Send RenderViewReady to observers once the process is launched, but not
+ // re-entrantly.
+ void PostRenderViewReady();
+ void RenderViewReady();
// TODO(creis): Move to a private namespace on RenderFrameHostImpl.
// Delay to wait on closing the WebContents for a beforeunload/unload handler
@@ -476,6 +480,8 @@ class CONTENT_EXPORT RenderViewHostImpl
bool updating_web_preferences_;
+ bool render_view_ready_on_process_launch_;
+
base::WeakPtrFactory<RenderViewHostImpl> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(RenderViewHostImpl);
« no previous file with comments | « content/browser/renderer_host/render_process_host_impl.cc ('k') | content/browser/renderer_host/render_view_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698