Issue 1380573003: Remove 2-stage RenderWidget initialization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1380573003: Remove 2-stage RenderWidget initialization (Closed)

Created:
5 years, 2 months ago by piman

Modified:
5 years, 2 months ago

Reviewers:

CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove 2-stage RenderWidget initialization This is like https://codereview.chromium.org/1369603003/ but with delaying the RenderViewReady callback, for trybots BUG=

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix racy test #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+126 lines, -87 lines)			Patch
M	chrome/browser/apps/guest_view/web_view_browsertest.cc	View	1 2	2 chunks	+26 lines, -16 lines	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.h	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.cc	View	1	5 chunks	+30 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host_impl.h	View		4 chunks	+7 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/render_view_host_impl.cc	View		7 chunks	+28 lines, -8 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_impl.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/render_widget_host_impl.cc	View		4 chunks	+1 line, -8 lines	0 comments	Download
M	content/common/swapped_out_messages.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/common/view_messages.h	View	1	3 chunks	+2 lines, -12 lines	0 comments	Download
M	content/public/browser/render_process_host.h	View	1	2 chunks	+15 lines, -3 lines	0 comments	Download
M	content/public/browser/render_process_host_observer.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	content/public/test/mock_render_process_host.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/public/test/mock_render_process_host.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/renderer/render_view_impl.cc	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	content/renderer/render_widget.h	View		3 chunks	+1 line, -7 lines	0 comments	Download
M	content/renderer/render_widget.cc	View	1	6 chunks	+1 line, -26 lines	0 comments	Download