third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp - Issue 1380573002: DevTools: fix evaluation on the last async call stack in chain

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp

Issue 1380573002: DevTools: fix evaluation on the last async call stack in chain (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-xhrs-expected.txt ('K') | « third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-xhrs-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp

diff --git a/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp b/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp

index bc253cfb9f90c8e8c1a8375ad6796549db2d3683..794c018277d8f0f44b6b4fa36bb4b75a618c493b 100644

--- a/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp

+++ b/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp

@@ -886,7 +886,7 @@ bool V8DebuggerAgentImpl::callStackForId(ErrorString* errorString, const RemoteC

*isAsync = false;

return true;

}

- if (!m_currentAsyncCallChain || asyncOrdinal < 1 || asyncOrdinal >= m_currentAsyncCallChain->callStacks().size()) {

+ if (!m_currentAsyncCallChain || asyncOrdinal < 1 || asyncOrdinal > m_currentAsyncCallChain->callStacks().size()) {

*errorString = "Async call stack not found";

return false;

}