Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1380573002: DevTools: fix evaluation on the last async call stack in chain (Closed)

Created:
5 years, 2 months ago by yurys
Modified:
5 years, 2 months ago
Reviewers:
kozy
CC:
blink-reviews, tim+watch_chromium.org, caseq+blink_chromium.org, zea+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, plaree+watch_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix evaluation on the last async call stack in chain Evaluation on the oldest async call stack in the chain now works fine. Drive-by: all async call stacks are now printed in the async call stack tests (before this patch we would stop once testFunction is found in one of the stacks). BUG=537021 Committed: https://crrev.com/a0c3f1c6249deadad09cd9cf0d7a6ad0646fbf08 Cr-Commit-Position: refs/heads/master@{#351399}

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comments #

Patch Set 3 : Rebaselined async-callstack-filesystem.html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -10 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js View 1 4 chunks +12 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/filesystem/async-callstack-filesystem-expected.txt View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-eval.html View 3 chunks +19 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-eval-expected.txt View 1 1 chunk +8 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-events-expected.txt View 1 2 chunks +12 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-expected.txt View 1 4 chunks +15 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-get-as-string-expected.txt View 1 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-indexed-db-expected.txt View 1 3 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-mutation-observer-expected.txt View 1 4 chunks +12 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-object-observe-expected.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-post-message-expected.txt View 1 3 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-promises-expected.txt View 1 8 chunks +24 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-scripted-scroll-expected.txt View 1 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-set-interval-expected.txt View 1 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-web-sql-expected.txt View 1 5 chunks +15 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-xhrs-expected.txt View 1 9 chunks +27 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (10 generated)
yurys
5 years, 2 months ago (2015-09-29 18:08:17 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380573002/1
5 years, 2 months ago (2015-09-29 18:09:14 UTC) #4
kozy
lgtm % nits https://codereview.chromium.org/1380573002/diff/1/third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-xhrs-expected.txt File third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-xhrs-expected.txt (right): https://codereview.chromium.org/1380573002/diff/1/third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-xhrs-expected.txt#newcode86 third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-xhrs-expected.txt:86: <... skipeed remaining frames ...> nit: ...
5 years, 2 months ago (2015-09-29 18:12:27 UTC) #5
yurys
addressed comments
5 years, 2 months ago (2015-09-29 18:13:28 UTC) #6
yurys
https://codereview.chromium.org/1380573002/diff/1/third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-xhrs-expected.txt File third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-xhrs-expected.txt (right): https://codereview.chromium.org/1380573002/diff/1/third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-xhrs-expected.txt#newcode86 third_party/WebKit/LayoutTests/inspector/sources/debugger-async/async-callstack-xhrs-expected.txt:86: <... skipeed remaining frames ...> On 2015/09/29 18:12:27, kozyatinskiy ...
5 years, 2 months ago (2015-09-29 18:13:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380573002/20001
5 years, 2 months ago (2015-09-29 18:14:39 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/113793)
5 years, 2 months ago (2015-09-29 18:18:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380573002/20001
5 years, 2 months ago (2015-09-29 19:05:29 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380573002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380573002/40001
5 years, 2 months ago (2015-09-29 19:09:10 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/127161)
5 years, 2 months ago (2015-09-29 19:38:36 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380573002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380573002/40001
5 years, 2 months ago (2015-09-29 20:20:23 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-09-29 21:08:37 UTC) #22
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 21:09:37 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a0c3f1c6249deadad09cd9cf0d7a6ad0646fbf08
Cr-Commit-Position: refs/heads/master@{#351399}

Powered by Google App Engine
This is Rietveld 408576698