[Chromecast] Remove use of VIDEO_HOLE

[Chromecast] Remove use of VIDEO_HOLE

Removed the switch to re-enable old VIDEO_HOLE path as the overlay
path appears to be working correctly.

BUG=469374
Committed: https://crrev.com/d2b919284b79346539b438641f6a3252dccb113b
Cr-Commit-Position: refs/heads/master@{#351571}

[halliwell, 2015-09-29 15:00:15]

halliwell@chromium.org changed reviewers:
+ dcheng@chromium.org, servolk@chromium.org, slan@chromium.org

[halliwell, 2015-09-29 15:01:06]

dcheng@ for removal of IPC message in cma_messages.h

[slan, 2015-09-29 15:32:48]

Do you want to remove the conditions linked below?

https://code.google.com/p/chromium/codesearch#chromium/src/build/common.gypi&...
https://code.google.com/p/chromium/codesearch#chromium/src/build/config/featu...

https://codereview.chromium.org/1380533002/diff/20001/chromecast/base/chromec...
File chromecast/base/chromecast_switches.cc (left):

https://codereview.chromium.org/1380533002/diff/20001/chromecast/base/chromec...
chromecast/base/chromecast_switches.cc:18: const char
kEnableLegacyHolePunching[] = "enable-legacy-hole-punching";
This is declared in chromecast_switches.h, remove that too.

[halliwell, 2015-09-29 15:41:42]

On 2015/09/29 15:32:48, slan wrote:
> Do you want to remove the conditions linked below?
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/build/common.gypi&...
>
https://code.google.com/p/chromium/codesearch#chromium/src/build/config/featu...
> 
>
https://codereview.chromium.org/1380533002/diff/20001/chromecast/base/chromec...
> File chromecast/base/chromecast_switches.cc (left):
> 
>
https://codereview.chromium.org/1380533002/diff/20001/chromecast/base/chromec...
> chromecast/base/chromecast_switches.cc:18: const char
> kEnableLegacyHolePunching[] = "enable-legacy-hole-punching";
> This is declared in chromecast_switches.h, remove that too.

Doh - yes, all removed.

[halliwell, 2015-09-29 15:44:03]

halliwell@chromium.org changed reviewers:
+ dpranke@chromium.org

[halliwell, 2015-09-29 15:44:29]

+dpranke@ for build/ changes

[slan, 2015-09-29 16:12:02]

A couple of build nits. Overall looks good.

https://codereview.chromium.org/1380533002/diff/40001/chromecast/browser/medi...
File chromecast/browser/media/cma_message_filter_host.cc (left):

https://codereview.chromium.org/1380533002/diff/40001/chromecast/browser/medi...
chromecast/browser/media/cma_message_filter_host.cc:28: #include
"ui/gfx/geometry/quad_f.h"
You should be able to remove the dependency on ui/gfx/geometry in GN

https://codereview.chromium.org/1380533002/diff/40001/chromecast/media/cma/fi...
File chromecast/media/cma/filters/hole_frame_factory.cc (left):

https://codereview.chromium.org/1380533002/diff/40001/chromecast/media/cma/fi...
chromecast/media/cma/filters/hole_frame_factory.cc:10: #include
"chromecast/base/chromecast_switches.h"
Remove GN dep on chromecast/base

[dcheng, 2015-09-29 17:10:34]

removal-only ipc changes lgtm

[Dirk Pranke, 2015-09-29 17:20:59]

build/ changes lgtm.

[halliwell, 2015-09-30 14:36:15]

https://codereview.chromium.org/1380533002/diff/40001/chromecast/browser/medi...
File chromecast/browser/media/cma_message_filter_host.cc (left):

https://codereview.chromium.org/1380533002/diff/40001/chromecast/browser/medi...
chromecast/browser/media/cma_message_filter_host.cc:28: #include
"ui/gfx/geometry/quad_f.h"
On 2015/09/29 16:12:01, slan wrote:
> You should be able to remove the dependency on ui/gfx/geometry in GN 

Done.

https://codereview.chromium.org/1380533002/diff/40001/chromecast/media/cma/fi...
File chromecast/media/cma/filters/hole_frame_factory.cc (left):

https://codereview.chromium.org/1380533002/diff/40001/chromecast/media/cma/fi...
chromecast/media/cma/filters/hole_frame_factory.cc:10: #include
"chromecast/base/chromecast_switches.h"
On 2015/09/29 16:12:02, slan wrote:
> Remove GN dep on chromecast/base

Done.

[halliwell, 2015-09-30 14:36:40]

The CQ bit was checked by halliwell@chromium.org

[halliwell, 2015-09-30 14:36:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/1380533002/#ps60001
(title: "Remove obsolete gn dependencies")

[commit-bot: I haz the power, 2015-09-30 14:36:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1380533002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1380533002/60001

[slan, 2015-09-30 14:45:17]

lgtm

[commit-bot: I haz the power, 2015-09-30 16:08:46]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-09-30 16:10:04]

Patchset 4 (id:??) landed as
https://crrev.com/d2b919284b79346539b438641f6a3252dccb113b
Cr-Commit-Position: refs/heads/master@{#351571}