Issue 138053006: [GCM] Fix use after free memory issue in gcm store

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 138053006: [GCM] Fix use after free memory issue in gcm store (Closed)

Created:
6 years, 11 months ago by Nicolas Zea

Modified:
6 years, 11 months ago

Reviewers:
fgorski

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[GCM] Fix use after free memory issue in gcm store leveldb::Slice holds a pointer to the string passed to it, so the string must outlive the slice itself. BUG=284553 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245154

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -11 lines)			Patch
	M	google_apis/gcm/engine/gcm_store_impl.cc	View		9 chunks	+22 lines, -11 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/138053006/1

6 years, 11 months ago (2014-01-15 21:29:23 UTC) #3

Message was sent while issue was closed.

Change committed as 245154