Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 1380523002: [heap] Less aggressive inlining of IncrementalMarking code. (Closed)

Created:
5 years, 2 months ago by Michael Starzinger
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Less aggressive inlining of IncrementalMarking code. This moves some methods of IncrementalMarking from the inlined header into the compilation unit. The methods in question are either not hot or are being called through a non-inline function already. R=hpayer@chromium.org Committed: https://crrev.com/9e0e7273c658a2f0a64bc6f5731f233aab4a9f62 Cr-Commit-Position: refs/heads/master@{#31017}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -87 lines) Patch
M src/heap/heap-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/incremental-marking.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/heap/incremental-marking.cc View 2 chunks +82 lines, -0 lines 0 comments Download
M src/heap/incremental-marking-inl.h View 3 chunks +5 lines, -84 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 2 months ago (2015-09-29 11:34:07 UTC) #1
Hannes Payer (out of office)
lgtm
5 years, 2 months ago (2015-09-29 16:58:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380523002/1
5 years, 2 months ago (2015-09-30 08:22:25 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-30 08:24:05 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 08:24:24 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e0e7273c658a2f0a64bc6f5731f233aab4a9f62
Cr-Commit-Position: refs/heads/master@{#31017}

Powered by Google App Engine
This is Rietveld 408576698