Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2828)

Issue 1380493004: VAVDA: Don't pass coded size as visible rect to PictureReady. (Closed)

Created:
5 years, 2 months ago by Pawel Osciak
Modified:
5 years, 2 months ago
Reviewers:
kcwu, wuchengli, hshi1
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

VAVDA: Don't pass coded size as visible rect to PictureReady. Passing (0,0) visible rect to PictureReady() results in the client using container-provided visible rect, which is what should be done until we add plumbing for passing visible size parsed from the stream instead. BUG=537029 TEST=vdatest,video playback Committed: https://crrev.com/96712c06bd450964419c15e66b277a80e2b6cd1e Cr-Commit-Position: refs/heads/master@{#351340}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M content/common/gpu/media/vaapi_video_decode_accelerator.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Pawel Osciak
ptal
5 years, 2 months ago (2015-09-29 09:11:13 UTC) #2
hshi1
On 2015/09/29 09:11:13, Pawel Osciak wrote: > ptal LGtM
5 years, 2 months ago (2015-09-29 13:19:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380493004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380493004/1
5 years, 2 months ago (2015-09-29 16:13:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-29 16:44:32 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 16:45:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96712c06bd450964419c15e66b277a80e2b6cd1e
Cr-Commit-Position: refs/heads/master@{#351340}

Powered by Google App Engine
This is Rietveld 408576698