Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 1380473002: Revert of Linux: Depend on liberation-fonts package for RPMs. (Closed)

Created:
5 years, 2 months ago by Lei Zhang
Modified:
5 years, 2 months ago
Reviewers:
Michael Moss
CC:
chromium-reviews, grt+watch_chromium.org, Michael Moss, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Linux: Depend on liberation-fonts package for RPMs. (patchset #1 id:1 of https://codereview.chromium.org/1358903005/ ) Reason for revert: Fedora 21 is still broken. Original issue's description: > Linux: Depend on liberation-fonts package for RPMs. > > The previous try in r342645 was reverted because Fedora did not have a > liberation-fonts virtual package. Fedora has since added the missing > virtual pacakge per our request to supported distros - Fedora 21 and > newer. > > So now we can fix the mismatch vs .debs, which added this dependency in > r342854. > > BUG=369991 > > Committed: https://crrev.com/a6df68559fd91f3bf3273c5e46d1c6a7b2132b8c > Cr-Commit-Position: refs/heads/master@{#350101} TBR=mmoss@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=369991 Committed: https://crrev.com/a103bac9350268c02dea6ab15a54e5eda9e2afb8 Cr-Commit-Position: refs/heads/master@{#351261}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/installer/linux/rpm/build.sh View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
Created Revert of Linux: Depend on liberation-fonts package for RPMs.
5 years, 2 months ago (2015-09-29 05:54:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380473002/1
5 years, 2 months ago (2015-09-29 05:54:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-29 05:55:23 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 05:56:03 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a103bac9350268c02dea6ab15a54e5eda9e2afb8
Cr-Commit-Position: refs/heads/master@{#351261}

Powered by Google App Engine
This is Rietveld 408576698