Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 1380373002: Fix another bug in the gn_roll script. (Closed)

Created:
5 years, 2 months ago by Dirk Pranke
Modified:
5 years, 2 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix another bug in the gn_roll script. We were not checking out the branch used to build gn before checking on the tryjob statuses for that branch. R=brettw@chromium.org BUG= Committed: https://crrev.com/3862a3e5baf3e0e5c867d82df6615414ae914855 Cr-Commit-Position: refs/heads/master@{#352145}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M tools/gn/bin/roll_gn.py View 3 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Dirk Pranke
5 years, 2 months ago (2015-10-02 20:50:06 UTC) #1
brettw
lgtm
5 years, 2 months ago (2015-10-02 21:00:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380373002/1
5 years, 2 months ago (2015-10-02 21:11:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-02 21:54:22 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 21:55:22 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3862a3e5baf3e0e5c867d82df6615414ae914855
Cr-Commit-Position: refs/heads/master@{#352145}

Powered by Google App Engine
This is Rietveld 408576698