Find a better place for setting Layout/Paint hook related flags.

third_party/WebKit/Source/web/WebViewImpl.cpp

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 3862 matching lines @@
                                      unsigned inactiveBackgroundColor,
                                      unsigned inactiveForegroundColor) {
 #if USE(DEFAULT_RENDER_THEME)
     LayoutThemeDefault::setSelectionColors(activeBackgroundColor, activeForegroundColor, inactiveBackgroundColor, inactiveForegroundColor);
     LayoutTheme::theme().platformColorsDidChange();
 #endif
 }
 
 void WebViewImpl::didCommitLoad(bool isNewNavigation, bool isNavigationWithinPage)
 {
-    if (isNewNavigation && !isNavigationWithinPage) {
-        pageScaleConstraintsSet().setNeedsReset(true);
-        m_pageImportanceSignals.onCommitLoad();
+    if (!isNavigationWithinPage) {
+        m_shouldDispatchFirstVisuallyNonEmptyLayout = true;
+        m_shouldDispatchFirstLayoutAfterFinishedParsing = true;
+
+        if (isNewNavigation) {
+            pageScaleConstraintsSet().setNeedsReset(true);
+            m_pageImportanceSignals.onCommitLoad();

[Alexander Semashko, 2015/10/05 13:11:11]

As a side question, do these two lines need to be under
"if (isNewNavigation)"? Looks like we have to exec them on every commit
(including, for example, BackForwardCommit).

I'm adding the authors of these lines to look at this.

[bokan, 2015/10/05 18:03:30]

I can only speak to the setNeedsReset on pageScaleConstraintsSet: It does need
to be limited to a new navigation since things like history navigations will
restore page scale to the saved value in the HistoryItem.

+        }
     }
 
     // Give the visual viewport's scroll layer its initial size.
     page()->frameHost().visualViewport().mainFrameDidChangeSize();
 
     // Make sure link highlight from previous page is cleared.
     m_linkHighlights.clear();
     endActiveFlingAnimation();
     m_userGestureObserved = false;
 }
@@ skipping 260 matching lines @@
         m_layerTreeView->setVisible(visible);
     } else {
         m_rootGraphicsLayer = nullptr;
         m_rootLayer = nullptr;
         m_rootTransformLayer = nullptr;
         // This means that we're transitioning to a new page. Suppress
         // commits until Blink generates invalidations so we don't
         // attempt to paint too early in the next page load.
         m_layerTreeView->setDeferCommits(true);
         m_layerTreeView->clearRootLayer();
-        m_shouldDispatchFirstVisuallyNonEmptyLayout = true;
-        m_shouldDispatchFirstLayoutAfterFinishedParsing = true;
         page()->frameHost().visualViewport().clearLayersForTreeView(m_layerTreeView);
     }
 }
 
 void WebViewImpl::invalidateRect(const IntRect& rect)
 {
     if (m_layerTreeView)
         updateLayerTreeViewport();
     else if (m_client)
         m_client->didInvalidateRect(rect);
@@ skipping 275 matching lines @@
     if (m_pageColorOverlay)
         m_pageColorOverlay->update();
     if (InspectorOverlay* overlay = inspectorOverlay()) {
         PageOverlay* inspectorPageOverlay = overlay->pageOverlay();
         if (inspectorPageOverlay)
             inspectorPageOverlay->update();
     }
 }
 
 } // namespace blink