Source/core/dom/StyleElement.cpp - Issue 138033019: CSP 1.1: Apply hashes to style elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/StyleElement.cpp

Issue 138033019: CSP 1.1: Apply hashes to style elements. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/security/contentSecurityPolicy/1.1/stylehash-basic-blocked-expected.txt ('k') | Source/core/frame/ContentSecurityPolicy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/dom/StyleElement.cpp

diff --git a/Source/core/dom/StyleElement.cpp b/Source/core/dom/StyleElement.cpp

index 8681680d943ef0cbc37130cee12b9990786986e0..e744c9bc4318c1a673edc918f33598ba05c8b534 100644

--- a/Source/core/dom/StyleElement.cpp

+++ b/Source/core/dom/StyleElement.cpp

@@ -128,7 +128,7 @@ void StyleElement::createSheet(Element* e, const String& text)

// If type is empty or CSS, this is a CSS style sheet.

const AtomicString& type = this->type();

- bool passesContentSecurityPolicyChecks = document.contentSecurityPolicy()->allowStyleNonce(e->fastGetAttribute(HTMLNames::nonceAttr)) || document.contentSecurityPolicy()->allowInlineStyle(e->document().url(), m_startPosition.m_line);

+ bool passesContentSecurityPolicyChecks = document.contentSecurityPolicy()->allowStyleHash(text) || document.contentSecurityPolicy()->allowStyleNonce(e->fastGetAttribute(HTMLNames::nonceAttr)) || document.contentSecurityPolicy()->allowInlineStyle(e->document().url(), m_startPosition.m_line);

if (isCSS(e, type) && passesContentSecurityPolicyChecks) {

RefPtr<MediaQuerySet> mediaQueries = MediaQuerySet::create(media());