content/browser/web_contents/web_contents_view_aura.cc - Issue 138033014: Consistent fading behavior for touch editing handles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_view_aura.cc

Issue 138033014: Consistent fading behavior for touch editing handles (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fade out handles on destruction by default Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_view_aura.cc

diff --git a/content/browser/web_contents/web_contents_view_aura.cc b/content/browser/web_contents/web_contents_view_aura.cc

index 09fdb7dc46177c68219653bc212bd393a62a98c2..1c122604927c9248bb0ad267f6903f3ef7686eca 100644

--- a/content/browser/web_contents/web_contents_view_aura.cc

+++ b/content/browser/web_contents/web_contents_view_aura.cc

@@ -1405,7 +1405,7 @@ void WebContentsViewAura::SetOverscrollControllerEnabled(bool enabled) {

void WebContentsViewAura::ShowContextMenu(const ContextMenuParams& params) {

if (touch_editable_)

- touch_editable_->EndTouchEditing();

+ touch_editable_->EndTouchEditing(false);

if (delegate_) {

delegate_->ShowContextMenu(params);

// WARNING: we may have been deleted during the call to ShowContextMenu().

@@ -1436,7 +1436,7 @@ void WebContentsViewAura::StartDragging(

}

if (touch_editable_)

- touch_editable_->EndTouchEditing();

+ touch_editable_->EndTouchEditing(false);

ui::OSExchangeData::Provider* provider = ui::OSExchangeData::CreateProvider();

PrepareDragData(drop_data, provider, web_contents_);